[pkg-go] Bug#798585: golang-go-md2man-dev: v1.0.3 unusable as a library; please upgrade to snapshot

[Anthony Fok]

Package: golang-go-md2man-dev
Version: 1.0.3-1
Severity: important
Tags: upstream

Hello Tianon and friends,

While trying to build golang-github-spf13-cobra (See Bug#798416),
which Build-Depends on golang-go-md2man-dev, I ran into the following
error:

     debian/rules build
    dh build --buildsystem=golang --with=golang
       dh_testdir -O--buildsystem=golang
       dh_auto_configure -O--buildsystem=golang
       dh_auto_build -O--buildsystem=golang
    	go install -v github.com/spf13/cobra
    src/github.com/spf13/cobra/man_docs.go:24:2: cannot find package "github.com/cpuguy83/go-md2man/md2man" in any of:
    	/usr/lib/go/src/github.com/cpuguy83/go-md2man/md2man (from $GOROOT)
    	/home/foka/debian/go/golang-github-spf13-cobra/obj-x86_64-linux-gnu/src/github.com/cpuguy83/go-md2man/md2man (from $GOPATH)
    dh_auto_build: go install -v github.com/spf13/cobra returned exit code 1
    debian/rules:4: recipe for target 'build' failed
    make: *** [build] Error 1

According to https://github.com/cpuguy83/go-md2man/pull/14
"Pull Request #14: md2man usable as a library (again)" by @eparis
(my comments in square brackets):

    [commit] d92bbe0 [coinciding with the upstream go-md2man v1.0.3 release
    on 17 Jun 2015] moved things from [the] mangen [directory] into
    the root subdir and changed the package to main. While this makes
    sense for this utility[,] others use go-md2man to generate docs
    automatically.
    Instead of building a binary to do it. Move roff back out to a package
    which can get included and used by others.
 
    Including github.com/cpuguy83/go-md2man seems reasonable but has 2
    problems.

    1) now you likely have two func main() in package main
    2) go-md2man defined in and out flags which would then show up in
    auto generated lists of flags in these other projects

To which go-md2man's author @cpuguy83 promptly replied:

    LGTM thanks, and sorry for breaking your setup!

and merged @eparis' pull request, moving the import path to
"github.com/cpuguy83/go-md2man/md2man".

According to build-rdep, there is no other package that Build-Depends
on golang-go-md2man-dev---golang-github-spf13-cobra will be the first
(docker.io Build-Depends on go-md2man only), so I foresee no breakage
by upgrading go-md2man to the latest upstream snapshot.

Meanwhile, on second thought, I decided to filee a GitHub issue asking
@cpuguy83 to consider releasing the latest snapshot as v1.0.4:

    https://github.com/cpuguy83/go-md2man/issues/15

So if you would rather wait for the v1.0.4 release, that is OK with me too.

Many thanks for your help!

Anthony Fok

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.1.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_CA.utf8, LC_CTYPE=en_CA.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages golang-go-md2man-dev depends on:
ii  golang-blackfriday-dev  1.2-2

golang-go-md2man-dev recommends no packages.

golang-go-md2man-dev suggests no packages.

-- no debconf information