[pkg-go] RFS: golang-github-bitly-simplejson

Michael Stapelberg stapelberg at debian.org
Sun Sep 13 17:03:04 UTC 2015


• debian/* is licensed under GPL-2+, but upstream is MIT. Consider
using the same license to avoid headaches when shipping patches.

• The package does not build with gbp:

/tmp/golang-github-bitly-go-simplejson master $ gbp buildpackage
--git-builder='sbuild -v -As --dist=unstable'
gbp:error: upstream/0.5.0-alpha_git20150401 is not a valid treeish

On Fri, Sep 11, 2015 at 1:30 AM, Potter, Tim (Cloud Services)
<timothy.potter at hpe.com> wrote:
> On 9 Sep 2015, at 2:07 pm, Paul Tagliamonte <paultag at debian.org> wrote:
>>
>> On Wed, Sep 09, 2015 at 03:46:41AM +0000, Potter, Tim (Cloud Services) wrote:
>>> On 9 Sep 2015, at 1:34 pm, Paul Tagliamonte <paultag at debian.org> wrote:
>>>>
>>>> On Wed, Sep 09, 2015 at 03:28:59AM +0000, Potter, Tim (Cloud Services) wrote:
>>>>> Hi everyone.  This package is required for bugsnag and I’ve just finished renaming
>>>>> it and testing against the new naming policy.
>>>>>
>>>>> Could someone please review and upload?
>>>>
>>>> Ah, your RFS was missing a -go :) -- package name is
>>>> golang-github-bitly-go-simplejson for those at home -- as a result, your
>>>> Vcs-* headers look a bit off :)
>>>
>>> Yes - sorry about that.  The extra -go is necessary.
>>>
>>> I've updated the Vcs-* fields now.
>>
>> Looks great. I spotted an issue where d/control claimed 0.4.3, source
>> was from 0.5.0. Tim's on the job, just noting it for the channel. After
>> that's clear, it looked good to me.
>
> I  investigated a bit and decided to rename the version number to 0.5.0-alpha to
> reflect what’s in the code.  Good catch though.
>
> This should be ready for uploading now.
>
>
> Thanks!
>
> Tim.
> _______________________________________________
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers



-- 
Best regards,
Michael



More information about the Pkg-go-maintainers mailing list