[pkg-go] May I update golang-testify and golang-toml to latest version?

Anthony Fok foka at debian.org
Thu Sep 24 17:42:48 UTC 2015


Hello Jelmer,

I am in the process of preparing Hugo the static website generator[1]
for upload to Debian.[2]

[1] http://gohugo.io/  [2] https://bugs.debian.org/798418

I ran into the following errors in a "gbp buildpackage" run:

    # github.com/spf13/hugo/tpl
    src/github.com/spf13/hugo/tpl/template_resources_test.go:244:
    undefined: assert.EqualValues
    src/github.com/spf13/hugo/tpl/template_resources_test.go:273:
    undefined: assert.EqualValues
    src/github.com/spf13/hugo/tpl/template_resources_test.go:304:
    undefined: assert.EqualValues

It turns out that assert.EqualValues was added to stretchr/testify
in February 2015, two months newer than the current
golang-testify (0.0~git20141213-1) package in Debian:

    commit 6cfa05f71da5d70224348871704245dae31ef678
    Merge: 43d0eed e73f5c7
    Author: Tyler <tylerb at users.noreply.github.com>
    Date:   Tue Feb 10 18:00:25 2015 -0700
    
        Merge pull request #130 from pquerna/add_assert_equal_values
        
        Add assert.EqualValues, which attempts to convert types to
        test equality
    
    commit e73f5c7e390143575f6513310ff6e30963b0b23a
    Author: Paul Querna <pquerna at apache.org>
    Date:   Tue Feb 10 16:51:45 2015 -0800
    
        Add assert.EqualValues, which attempts to convert types to
        test equality. Fixes #129

Since I need to upgrade my local copy of golang-testify-dev anyway,
in order to finish my Hugo packaging, may I go ahead and push it to
git.debian.org and upload it to ftp-master?  (Or do you prefer
upgrading golang-testify yourself?)

Besides upgrading to HEAD (1.0+git20150914.42.b8dc1ce), I would like to
rename the library package to golang-github-stretchr-testify-dev, and
perhaps even rename the source package to golang-github-stretchr-testify,
as per the latest Naming Conventions specified at
http://pkg-go.alioth.debian.org/packaging.html#_naming_conventions_2
May I do that too?  :-)


And finally, I would like to have golang-toml upgraded too because IIRC
there has been some bug fixes in the upstream BurntSushi/toml package
that solved problems that some Hugo users ran into.  This is not as urgent
though as Hugo builds fine with the current golang-toml-dev (0.1.0-1).
Would you like to upgrade golang-toml yourself?  Or would you prefer
that someone else (e.g. me) to do it?

Regarding golang-toml, I have another favour to ask of you.  :-)
Examining http://anonscm.debian.org/cgit/pkg-go/packages/golang-toml.git ,
I noticed that only the "master" branch was uploaded, but no "upstream"
or "pristine-tar" branches.  Could you please push them to git.debian.org
when you have time?  Many thanks!

Meanwhile, http://anonscm.debian.org/cgit/pkg-go/packages/golang-testify.git
does not have a pristine-tar branch either.  Do you happen to have the
local pristine-tar branch on your computer?

Many thanks for staying with me in this long and wordy email.  :-)

Cheers,
Anthony



More information about the Pkg-go-maintainers mailing list