[pkg-go] Bug#801593: Bug#801593: ratt does not find all reverse build dependencies

[Johannes Schauer]

Hi,

Quoting Michael Stapelberg (2015-10-14 19:04:00)
> With an arbitrarily selected package, I’m not getting the expected result —
> dose-ceve lists fewer dependencies than ratt:
> 
> Running ratt as-is:
> 
> $ go run ratt.go -dry_run
> /tmp/golang-golang-x-tools_0.0\~git20150716.0.87156cb+dfsg1-4_amd64.changes
> 2015/10/14 18:57:01 Loading changes file
> "/tmp/golang-golang-x-tools_0.0~git20150716.0.87156cb+dfsg1-4_amd64.changes"
> 2015/10/14 18:57:01  - 4 binary packages: golang-golang-x-tools
> golang-go.tools golang-golang-x-tools-dev golang-go.tools-dev
> 2015/10/14 18:57:01  - corresponding .debs (will be injected when building):
> 2015/10/14 18:57:01
> golang-go.tools-dev_0.0~git20150716.0.87156cb+dfsg1-4_all.deb
> 2015/10/14 18:57:01
> golang-go.tools_0.0~git20150716.0.87156cb+dfsg1-4_amd64.deb
> 2015/10/14 18:57:01
> golang-golang-x-tools-dev_0.0~git20150716.0.87156cb+dfsg1-4_all.deb
> 2015/10/14 18:57:01
> golang-golang-x-tools_0.0~git20150716.0.87156cb+dfsg1-4_amd64.deb
> 2015/10/14 18:57:01 Loading sources index
> "/var/lib/apt/lists/ftp.ch.debian.org_debian_dists_unstable_contrib_source_Sources"
> 2015/10/14 18:57:01 Loading sources index
> "/var/lib/apt/lists/ftp.ch.debian.org_debian_dists_unstable_main_source_Sources"
> 2015/10/14 18:57:03 Loading sources index
> "/var/lib/apt/lists/ftp.ch.debian.org_debian_dists_unstable_non-free_source_Sources"
> 2015/10/14 18:57:03 Setting -sbuild_dist=unstable (from .changes file)
> 2015/10/14 18:57:03 Building aptly_0.9.5-2 […]
> 2015/10/14 18:57:03 Building dh-make-golang_0.0~git20150913.0.1221041-1 […]
> 2015/10/14 18:57:03 Building etcd_2.2.0+dfsg-2 […]
> 2015/10/14 18:57:03 Building golang-github-aws-aws-sdk-go_0.9.9+dfsg-1 […]
> 2015/10/14 18:57:03 Building golint_0.0+git20150623.7b7f436-1 […]
> 
> (commands redacted for readability)
> 
> Whereas using dose-ceve:
> 
> $ dose-ceve --deb-native-arch=amd64 -T debsrc -r golang-golang-x-tools -G
> pkg
> deb:///var/lib/apt/lists/ftp.ch.debian.org_debian_dists_unstable_main_binary-amd64_Packages
> debsrc:///var/lib/apt/lists/ftp.ch.debian.org_debian_dists_unstable_main_source_Sources
> 
> Package: etcd
> Version: 2.2.0+dfsg-2
> Architecture: any all
> Build-Depends: debhelper (>= 9), dh-golang (>= 1.6), dh-systemd,
> golang-clockwork-dev | golang-github-jonboulle-clockwork-dev,
> golang-codegangsta-cli-dev | golang-github-codegangsta-cli-dev,
> golang-context-dev | golang-github-gorilla-context-dev,
> golang-coreos-log-dev | golang-github-coreos-go-log-dev, golang-etcd-dev |
> golang-github-coreos-go-etcd-dev, golang-github-boltdb-bolt-dev,
> golang-github-bradfitz-http2-dev, golang-github-coreos-go-systemd-dev,
> golang-github-google-btree-dev, golang-github-gorilla-mux-dev |
> golang-mux-dev, golang-github-ugorji-go-codec-dev, golang-glog-dev |
> golang-github-golang-glog-dev, golang-go, golang-go-semver-dev |
> golang-github-coreos-go-semver-dev, golang-go.crypto-dev |
> golang-golang-x-go.crypto-dev, golang-go.tools, golang-gogoprotobuf-dev (>=
> 0.0~git20150828~) | golang-github-gogo-protobuf-dev (>= 0.0~git20150828~),
> golang-golang-x-net-dev, golang-golang-x-oauth2-dev,
> golang-golang-x-sys-dev, golang-google-cloud-compute-metadata-dev,
> golang-goprotobuf-dev | golang-github-golang-protobuf-dev,
> golang-metrics-dev | golang-github-rcrowley-go-metrics-dev, golang-objx-dev
> | golang-github-stretchr-objx-dev, golang-procfs-dev |
> golang-github-prometheus-procfs-dev, golang-prometheus-client-dev |
> golang-github-prometheus-client-golang-dev, golang-protobuf-extensions-dev
> | golang-github-matttproud-golang-protobuf-extensions-dev,
> golang-testify-dev | golang-github-stretchr-testify-dev, golang-toml-dev |
> golang-github-burntsushi-toml-dev, libprotobuf-dev, protobuf-compiler
> 
> Package: aptly
> Version: 0.9.5-2
> Architecture: any
> Build-Depends: debhelper (>= 9.0.0), golang (>= 1.1), golang-go.tools,
> bash-completion
> 
> Do you know where that difference comes from?

If I understand the output of ratt correctly, then it finds that the following
source packages build depend on golang-golang-x-tools while ceve thinks they do
not:

 - dh-make-golang
 - golang-github-aws-aws-sdk-go
 - golint

The solution seems to be that above three source packages just do not build
depend on golang-golang-x-tools or do you see a dependency path from any of
these three source packages to golang-golang-x-tools? I do not.

Thanks!

cheers, josch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20151014/2b64aa21/attachment.sig>