[pkg-go] Bug#818580: ITP: golang-github-prometheus-client-model -- data model artifacts for Prometheus

[Martín Ferrari]

On 18/03/16 23:06, Dmitry Smirnov wrote:

>> The client model is just a
>> compiled protobuf description, and I included it in the common libraries.
> 
> Understood. I've noticed that when I was packaging client_model. I've decided 
> to create another package because client_model have its own repository and 
> because it is not present in 
> 
>     https://github.com/prometheus/common
> 
> Also I'd like to avoid patching namespace...

Well, now we have two versions of the same thing in the repository,
which will need to be maintained separately. We could have instead fixed
the namespace issue.

But this goes way further than that:

* You are packaging the whole upstream tree, which is supposed to
provide bindings for many different languages, which you are not
providing, nor the naming of the source package is reflecting.

* In nomad you are also build-depending on the common library, which
includes the protobuf. So instead of building a different package you
could have renamed the protobuf file, or something.

* But actually, nomad *does not* use this libraries (I just ran grep -r
on the source tree). These build-dependenies are spurious, it is
actually a dependency of golang-github-armon-go-metrics, which uses the
prometheus client library, which makes all this stuff transparent.



Dmitry, I have to be blunt, I find this attitude pretty upsetting, and
very much not in the spirit of team work..

IF there was some issue (but there was none), we could have tried to
find some solution that avoided this.

You saw the package was a duplicate, and that it was owned by the team
even, but ignored that.

It is already the third time I have to tell you that you are about to
upload a duplicate package because you had not looked before. Please, be
more careful, otherwise it is the team that will have to pick up the
pieces of all this.


-- 
Martín Ferrari (Tincho)