[pkg-go] fsnotify

Martín Ferrari tincho at tincho.org
Thu Apr 21 01:21:43 UTC 2016


Hi all,

Starting from a build failure in prometheus, I identified a bug in
fsnotify, which then propagated to golang itself and x/sys.

This has now been fixed (for arm64, powerpc still pending), and I want
to upload the new version that includes the fix.

The problem is that fsnotify went through two important changes recently:

1. They changed the organisation name in github from go-fsnotify to
fsnotify.
2. They provide versioned stable API namespace using gopkg.in/fsnotify.v1.

So, now I don't know what to do with the package naming. Currently it
reflects the go-fsnotify namespace, and still carries the old
golang-fsnotify transitional package.

Prometheus -for example- imports gopkg.in/fsnotify.v1, but the fsnotify
tests actually import github.com/fsnotify/fsnotify. Making things more
confusing.

I see two options:

1. Transition to the new github org name
(golang-github-fsnotify-fsnotify-dev), adding new
breaks/replaces/provides, and also add a virtual provides for
golang-gopkg-fsnotify.v1.


2. Transition instead to golang-gopkg-fsnotify.v1, making it B/R/P
golang-github-go-fsnotify-fsnotify-dev, and provide
golang-github-fsnotify-fsnotify-dev for packages that use the
non-versioned namespace.


Option 1 would probably give trouble down the line if we ever want to
transition to 2, due to support of versioned B/R/P on virtual packages.
(not sure about this).

I think option 2 is the way to go, since that will free us from future
namespace stupidity, provides an stable API, and is consistent with
other packages using gopkg (yaml, check).

What do you guys think?

-- 
Martín Ferrari (Tincho)



More information about the Pkg-go-maintainers mailing list