[pkg-go] fsnotify

[Anthony Fok]

Hi Tincho,

On Fri, Apr 22, 2016 at 2:03 AM, Martín Ferrari <tincho at tincho.org> wrote:
> On 21/04/16 03:58, Anthony Fok wrote:
>
>> I would go with Option 1.  Upstream, i.e., Nathan Youngman, is actually
>> trying to move away from gopkg.in, so the recommended import path is
>> "github.com/fsnotify/fsnotify" as of February 2016, and a few dependent
>> projects have already follow suit, see:
>
> Oh, this is actually a surprise to me. I thought that things like
> gopkg.in were the future.. damn.

I guess it depends.  For some Go developers, gopkg.in is the future;
for other Go developers, maybe not.  After all, gopkg.in seems to be a
nice offering by a Go company, but not an official offering from
Google, so there is no obligation to use it.  In this case, it is
simply that fsnotify's maintainer decided to move away from it, but
yaml.v2's maintainer is still using gopkg.in.

> So it seems that the new vendoring support is the reason, so more pain
> for us down the road.. /me not pleased
>
>> So, following @shurcooL's example, I went ahead and updated the
>> fsnotify import path for spf13/viper and spf13/hugo too.  I recommend
>> that you do the same for prometheus.
>
> Yeah. Anyway, we can provide the gopkg.in symlink for compat.

Yes, the gopkg.in symlink definitely should stay.

>> That said, since you already have 1.3.0-1 packaged, I think the
>> transition to golang-github-fsnotify-fsnotify-dev can happen in
>> 1.3.0-2 instead.  It is up to you.  :-)  If/when you do, please update
>
> Oh, no, I stopped myself from uploading yesterday so we could do any
> needed transition now. It makes more sense to do it in -1.

Sounds good to me!

>> debian/copyright and debian/watch too, and perhaps bump
>> Standards-Version to 3.9.8 (though Lintian hasn't caught up yet), and
>> perhaps update Vcs-Git to
>> https://anonscm.debian.org/git/pkg-go/packages/golang-fsnotify.git
>> too.  :-)
>
> Will do, although I am not sure if i will have any free time before
> monday (weekend away). So feel free to start if you want.

Thanks!  I will make these changes and upload 1.3.0-1 shortly.

Cheers,
Anthony