[pkg-go] RFC: Enhancements to dh-golang

Michael Hudson-Doyle michael.hudson at canonical.com
Thu May 12 19:31:01 UTC 2016


On 13 May 2016 at 00:52, Martín Ferrari <tincho at tincho.org> wrote:
> On 11/05/16 03:57, Michael Hudson-Doyle wrote:
>
>> +            } elsif ($File::Find::name =~ m%/testdata/%) {
>> +                # testdata directories are always copied
>
> Ah yes, but that is cheating in my opinion :) AFAIK, the 'testdata'
> directory is not special in go, and many packages have other names
> (fixtures is a common one). I think it is a bad idea to add this.

'testdata' is a little special to the Go tool: it ignores such
directories entirely, and it does seem to be pretty commonly used in
the random subset of packages I have in my GOPATH today and

https://codesearch.debian.net/perpackage-results/testdata%20path%3Adebian%2Frules%20/2/page_0

certainly shows lots of lines that could be removed if this was added
(in fact, maybe they would now cause errors or misbehave, which is
perhaps an argument against this change without some compat stuff...)

Cheers,
mwh



More information about the Pkg-go-maintainers mailing list