[pkg-go] Two remaining uploads for docker 1.11.0

[Potter, Tim (HPE Linux Support)]

On 24 May 2016, at 12:14 PM, Dmitry Smirnov <onlyjob at debian.org> wrote:
> 
> On Monday, 23 May 2016 4:58:01 PM AEST Tianon Gravi wrote:
>>> * golang-gocapability-dev
> 
> Uploaded.

Thanks!

>>> * golang-github-docker-go (new package, ITP #822219)
> 
> Wouldn't it be better to keep it private/bundled?
> 
> I doubt this particular library would be (re-)used by anything else...

Hey that's a really good idea.  I've been so obsessed with unbundling things I had
forgotten that sometimes it makes sense to keep things bundled.

[...]

>> | golang-google-grpc-dev is version constrainted >= 0.0~git20151216~
> 
> I've accidentally uploaded newer snapshot...
> I hope it won't be a problem...

Updating grpc is one of those "cross your fingers and hope it works" type of things. (-:

> Also I'm still getting the following build failures:
> 
> ~~~~
> # github.com/docker/docker/api/client
> src/github.com/docker/docker/api/client/trust.go:480: too many arguments in call to repo.CryptoService.Create

This might be linked to notary or the notary client somehow.  I forget the exact problem
but there were some crypto changes somewhere which required some patches.  I
don't get these problems building out of a fresh pbuilder chroot so maybe there is
something wrong with your environment?  Or maybe something wrong with mine
that's causing it to succeed when it should fail.  It would be nice to sort this out.

> # github.com/docker/docker/daemon/logger/awslogs
> src/github.com/docker/docker/daemon/logger/awslogs/cloudwatchlogs.go:72: undefined: defaults.DefaultConfig in defaults.DefaultConfig.Region
> src/github.com/docker/docker/daemon/logger/awslogs/cloudwatchlogs.go:72: cannot assign to defaults.DefaultConfig.Region
> src/github.com/docker/docker/daemon/logger/awslogs/cloudwatchlogs.go:124: undefined: defaults.DefaultConfig
> src/github.com/docker/docker/daemon/logger/awslogs/cloudwatchlogs.go:126: undefined: defaults.DefaultConfig in defaults.DefaultConfig.Merge

There should be a vendor version of github.com/aws/aws-sdk-go that has these symbols.
There turns out to be some breaking changes made in recent versions of this package.

I didn't end up unbundling a couple of dependencies because they were very difficult to fix
at the time.  I was hoping to revisit them after things had settled down a bit.  The aws-sdk-go
package is one of these (along with notary, grpc, and a private fork of golang-x-net with some
weird patches).


Tim.

> ~~~~
> 
> --
> Best wishes,
> Dmitry Smirnov.
> 
> ---
> 
> A man is his own easiest dupe, for what he wishes to be true he
> generally believes to be true.
>        -- Demosthenes, Third Olynthiac, sct. 19 (349 BCE)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20160524/ea227efc/attachment.sig>