[pkg-go] Bug#840744: Bug#840744: golang-dns: Packaging cleanups and new upstream release

[Guillem Jover]

Hi!

On Sat, 2016-10-15 at 02:54:01 +0200, Martín Ferrari wrote:
> On 14/10/16 22:18, Guillem Jover wrote:
> >> Here's a packaging cleanup and new upstream release request. (This one
> >> I also had packaged initially from scratch as I didn't find it :/.)
> >>
> >> Attached the working and tested patch. I've also renamed the Vcs
> >> fields to makes this less confusing overall, but that will require
> >> changes on the alioth side (probably rename + compat symlinks?).
> > 
> > Hmm, it seems that particular iteration was not working so much. :/
> > Attached a fixed version. With additional cleanups.
> 
> I merged this partially, and renamed the repo. There are some changes
> that I think are not correct:
> 
> * We are not using built-using in -dev packages any more. Somebody
> explained to me the reason for this, but I forgot :-)

Indeed, that does not make sense, because the -dev do not embed
anything from the built-using packages. They are only used for testing
purposes. As I mentioned on IRC I would swear I saw a warning about
this, but it seems I was wrong, and probably too tired. I'll go over
all submitted packaging and recheck them just in case.

> * I think the usage of _build as build directory is not needed.

I found it prettier to have the build directory not change depending
on the host. And because it's easier to deal with when debugging or
similar, the instructions are just “go check the built stuff under
_build”.

> * The old upstream name was wrong, and I don't think we have set a
> standard for this, but I usually use the import path for this.

I'm assuming we are talking about the Upstream-Name field here. In
which case I think I've mostly seen the repo name used in many other
golang packages. I thought about using the import path but that seems
redundant with the Source field?

> Also, you forgot to close the bug in the changelog :)

On the second iteration yes, on the first it didn't exist yet. ;)

> So, before I upload, let's discuss those pending changes.

It seems you might need to update to a new upstream snapshot too. :)

> PS: I also added a couple more cleanups.

Yeah, I've seen, thanks!

Regards,
Guillem