[pkg-go] Bug#851723: golang-github-elithrar-simple-scrypt: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:golang-github-elithrar-simple-scrypt
Version: 1.1+git20161119.3.2325946-1
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_testdir -i -O--buildsystem=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_autoreconf -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
   dh_auto_build -i -O--buildsystem=golang
	go install -v -p 1 github.com/elithrar/simple-scrypt
golang.org/x/crypto/pbkdf2
golang.org/x/crypto/scrypt
github.com/elithrar/simple-scrypt
   dh_auto_test -i -O--buildsystem=golang
	go test -v -p 1 github.com/elithrar/simple-scrypt
=== RUN   TestGenerateRandomBytes
--- PASS: TestGenerateRandomBytes (0.00s)
=== RUN   TestGenerateFromPassword
--- PASS: TestGenerateFromPassword (6.56s)
=== RUN   TestCompareHashAndPassword
--- PASS: TestCompareHashAndPassword (0.15s)
=== RUN   TestCost
--- PASS: TestCost (0.05s)
=== RUN   TestDecodeHash
--- PASS: TestDecodeHash (0.00s)
=== RUN   TestCalibrate
--- FAIL: TestCalibrate (5.71s)
	scrypt_test.go:137: GenerateFromPassword with scrypt.Params{N:524288, R:1, P:1, SaltLen:16, DKLen:32} took 249.695793ms (<nil>)
	scrypt_test.go:142: 0. GenerateFromPassword was too fast (wanted around 500ms, got 249.695793ms) with scrypt.Params{N:524288, R:1, P:1, SaltLen:16, DKLen:32}.
	scrypt_test.go:137: GenerateFromPassword with scrypt.Params{N:262144, R:1, P:4, SaltLen:16, DKLen:32} took 466.108213ms (<nil>)
	scrypt_test.go:137: GenerateFromPassword with scrypt.Params{N:131072, R:1, P:8, SaltLen:16, DKLen:32} took 451.196673ms (<nil>)
	scrypt_test.go:137: GenerateFromPassword with scrypt.Params{N:65536, R:1, P:18, SaltLen:16, DKLen:32} took 492.462842ms (<nil>)
	scrypt_test.go:137: GenerateFromPassword with scrypt.Params{N:8192, R:1, P:157, SaltLen:16, DKLen:32} took 425.840832ms (<nil>)
FAIL
exit status 1
FAIL	github.com/elithrar/simple-scrypt	12.502s
dh_auto_test: go test -v -p 1 github.com/elithrar/simple-scrypt returned exit code 1
debian/rules:4: recipe for target 'build-indep' failed
make: *** [build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/golang-github-elithrar-simple-scrypt/

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Thanks.