[pkg-go] Bug#853261: Bug#853261: golang-github-masterzen-winrm: FTBFS when built with dpkg-buildpackage -A

[Daniel Stender]

All right. Thx for the bug report & patch.

Best,
DS

On 30.01.2017 22:11, Santiago Vila wrote:
> Package: src:golang-github-masterzen-winrm
> Version: 0.0~git20160323.0752679-2
> Severity: serious
> Tags: patch
> 
> Dear maintainer:
> 
> I tried to build this package in stretch with "dpkg-buildpackage -A"
> but it failed:
> 
> --------------------------------------------------------------------------------
> [...]
>  debian/rules build-indep
> dh build-indep --buildsystem=golang --with=golang
>    dh_testdir -i -O--buildsystem=golang
>    dh_update_autotools_config -i -O--buildsystem=golang
>    dh_auto_configure -i -O--buildsystem=golang
>    dh_auto_build -i -O--buildsystem=golang
> 	go install -v -p 1 github.com/masterzen/winrm github.com/masterzen/winrm/soap github.com/masterzen/winrm/winrm
> github.com/masterzen/simplexml/dom
> github.com/masterzen/xmlpath
> github.com/masterzen/winrm/soap
> github.com/nu7hatch/gouuid
> github.com/masterzen/winrm/winrm
> github.com/masterzen/winrm
>    dh_auto_test -i -O--buildsystem=golang
> 	go test -v -p 1 github.com/masterzen/winrm github.com/masterzen/winrm/soap github.com/masterzen/winrm/winrm
> ?   	github.com/masterzen/winrm	[no test files]
> === RUN   Test
> OK: 1 passed
> --- PASS: Test (0.00s)
> === RUN   TestAddUsualNamespaces
> --- PASS: TestAddUsualNamespaces (0.00s)
> === RUN   TestSetTo
> --- PASS: TestSetTo (0.00s)
> PASS
> ok  	github.com/masterzen/winrm/soap	0.006s
> === RUN   Test
> OK: 27 passed
> --- PASS: Test (3.03s)
> PASS
> ok  	github.com/masterzen/winrm/winrm	3.039s
>  fakeroot debian/rules binary-indep
> dh binary-indep --buildsystem=golang --with=golang
>    dh_testroot -i -O--buildsystem=golang
>    dh_prep -i -O--buildsystem=golang
>    dh_auto_install -i -O--buildsystem=golang
> 	mkdir -p /<<BUILDDIR>>/golang-github-masterzen-winrm-0.0\~git20160323.0752679/debian/tmp/usr
> 	cp -r bin /<<BUILDDIR>>/golang-github-masterzen-winrm-0.0\~git20160323.0752679/debian/tmp/usr
> 	mkdir -p /<<BUILDDIR>>/golang-github-masterzen-winrm-0.0\~git20160323.0752679/debian/tmp/usr/share/gocode/src/github.com/masterzen/winrm
> 	cp -r -T src/github.com/masterzen/winrm /<<BUILDDIR>>/golang-github-masterzen-winrm-0.0\~git20160323.0752679/debian/tmp/usr/share/gocode/src/github.com/masterzen/winrm
>    debian/rules override_dh_install
> make[1]: Entering directory '/<<PKGBUILDDIR>>'
> dh_install
> mv -v debian/winrm/usr/bin/winrm debian/winrm/usr/bin/winrm-go
> mv: cannot stat 'debian/winrm/usr/bin/winrm': No such file or directory
> debian/rules:9: recipe for target 'override_dh_install' failed
> make[1]: *** [override_dh_install] Error 1
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> debian/rules:6: recipe for target 'binary-indep' failed
> make: *** [binary-indep] Error 2
> dpkg-buildpackage: error: fakeroot debian/rules binary-indep gave error exit status 2
> --------------------------------------------------------------------------------
> 
> This happens because we are creating arch-independent packages only,
> so debian/winrm/[...] does not exist, as "winrm" is Arch:any.
> 
> Trivial (but untested) patch follows.
> 
> Thanks.
> 
> --- a/debian/rules
> +++ b/debian/rules
> @@ -5,7 +5,7 @@
>  %:
>  	dh $@ --buildsystem=golang --with=golang
>  
> -override_dh_install:
> +override_dh_install-arch:
>  	dh_install
>  	mv -v debian/winrm/usr/bin/winrm debian/winrm/usr/bin/winrm-go
>  
> 
> _______________________________________________
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
> 
> 


-- 
4096R/DF5182C8
Debian Developer (stender at debian.org)
http://www.danielstender.com/