[pkg-go] Bug#854687: golang-github-prometheus-client-golang: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:golang-github-prometheus-client-golang
Version: 0.8.0-1
Severity: important

Dear maintainer:

I tried to build this package in stretch with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_testdir -i -O--buildsystem=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
	mkdir -p obj-x86_64-linux-gnu
dh_auto_configure: "github.com/prometheus/client_golang" is already installed. Please check for circular dependencies.

	Copy api/prometheus/api_test.go -> obj-x86_64-linux-gnu/src/github.com/prometheus/client_golang/api/prometheus/api_test.go
	Copy api/prometheus/api.go -> obj-x86_64-linux-gnu/src/github.com/prometheus/client_golang/api/prometheus/api.go
	Copy examples/random/main.go -> obj-x86_64-linux-gnu/src/github.com/prometheus/client_golang/examples/random/main.go
	Copy examples/simple/main.go -> obj-x86_64-linux-gnu/src/github.com/prometheus/client_golang/examples/simple/main.go
	Copy prometheus/summary.go -> obj-x86_64-linux-gnu/src/github.com/prometheus/client_golang/prometheus/summary.go
	Copy prometheus/example_clustermanager_test.go -> obj-x86_64-linux-gnu/src/github.com/prometheus/client_golang/prometheus/example_clustermanager_test.go

[... snipped ...]

--- PASS: TestMetricVecWithCollisions (0.00s)
=== RUN   TestCounterVecEndToEndWithCollision
--- PASS: TestCounterVecEndToEndWithCollision (0.00s)
=== RUN   TestHandler
--- PASS: TestHandler (0.01s)
=== RUN   TestRegisterWithOrGet
--- PASS: TestRegisterWithOrGet (0.00s)
=== RUN   ExampleGaugeFunc
--- PASS: ExampleGaugeFunc (0.00s)
=== RUN   ExampleCounter
--- PASS: ExampleCounter (0.00s)
=== RUN   ExampleLabelPairSorter
--- PASS: ExampleLabelPairSorter (0.00s)
=== RUN   ExampleRegister
--- PASS: ExampleRegister (0.00s)
=== RUN   ExampleSummary
--- PASS: ExampleSummary (0.00s)
=== RUN   ExampleSummaryVec
--- PASS: ExampleSummaryVec (0.02s)
=== RUN   ExampleNewConstSummary
--- PASS: ExampleNewConstSummary (0.00s)
=== RUN   ExampleHistogram
--- PASS: ExampleHistogram (0.00s)
=== RUN   ExampleNewConstHistogram
--- PASS: ExampleNewConstHistogram (0.00s)
=== RUN   ExampleGatherers
--- PASS: ExampleGatherers (0.01s)
=== RUN   ExampleExpvarCollector
--- PASS: ExampleExpvarCollector (0.00s)
FAIL
exit status 1
FAIL	github.com/prometheus/client_golang/prometheus	60.454s
=== RUN   TestHandlerErrorHandling
--- PASS: TestHandlerErrorHandling (0.00s)
PASS
ok  	github.com/prometheus/client_golang/prometheus/promhttp	0.008s
=== RUN   TestPush
--- PASS: TestPush (0.00s)
PASS
ok  	github.com/prometheus/client_golang/prometheus/push	0.009s
dh_auto_test: go test -v -p 1 github.com/prometheus/client_golang/api/prometheus github.com/prometheus/client_golang/prometheus github.com/prometheus/client_golang/prometheus/promhttp github.com/prometheus/client_golang/prometheus/push returned exit code 1
	cd /<<PKGBUILDDIR>>
debian/rules:13: recipe for target 'build-indep' failed
make: *** [build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2
--------------------------------------------------------------------------------

This is just how the build ends, not necessarily the relevant part.

I've put several build logs here:

https://people.debian.org/~sanvila/build-logs/golang-github-prometheus-client-golang/

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

The bug should be reproducible with sbuild on a single CPU virtual machine,
provided you try enough times (as the failure happens randomly).

Thanks.