[pkg-go] Bug#857656: [PATCH] c/binaries: amend go whitelist to cover all errors

[Michael Stapelberg]

Package: lintian
Version: 2.5.51
Severity: normal
Tags: patch

Please consider merging the attached patch.

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'testing-debug'), (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armel, mipsel, arm64

Kernel: Linux 4.9.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lintian depends on:
ii  binutils                          2.27.90.20170124-2
ii  bzip2                             1.0.6-8.1
ii  diffstat                          1.61-1
ii  file                              1:5.29-3
ii  gettext                           0.19.8.1-2
ii  intltool-debian                   0.35.0+20060710.4
ii  libapt-pkg-perl                   0.1.30
ii  libarchive-zip-perl               1.59-1
ii  libclass-accessor-perl            0.34-1
ii  libclone-perl                     0.38-2+b1
ii  libdpkg-perl                      1.18.22
ii  libemail-valid-perl               1.202-1
ii  libfile-basedir-perl              0.07-1
ii  libipc-run-perl                   0.94-1
ii  liblist-moreutils-perl            0.416-1+b1
ii  libparse-debianchangelog-perl     1.2.0-12
ii  libperl5.22 [libdigest-sha-perl]  5.22.2-5
ii  libperl5.24 [libdigest-sha-perl]  5.24.1-1
ii  libtext-levenshtein-perl          0.13-1
ii  libtimedate-perl                  2.3000-2
ii  liburi-perl                       1.71-1
ii  libyaml-libyaml-perl              0.63-2
ii  man-db                            2.7.6.1-2
ii  patchutils                        0.3.4-2
ii  perl                              5.24.1-1
ii  t1utils                           1.39-2
ii  xz-utils                          5.2.2-1.2+b1

Versions of packages lintian recommends:
ii  dpkg                                 1.18.22
pn  libperlio-gzip-perl                  <none>
ii  perl                                 5.24.1-1
ii  perl-modules-5.22 [libautodie-perl]  5.22.2-5
ii  perl-modules-5.24 [libautodie-perl]  5.24.1-1

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.18.22
ii  libhtml-parser-perl    3.72-3
ii  libtext-template-perl  1.46-1

-- no debconf information
-------------- next part --------------
>From a6a605806a0c52f723879eaf2f3ace92c46ec2b4 Mon Sep 17 00:00:00 2001
From: Michael Stapelberg <stapelberg at debian.org>
Date: Mon, 13 Mar 2017 20:30:40 +0100
Subject: [PATCH 3/3] c/binaries: amend go whitelist to cover all errors

---
 checks/binaries.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/checks/binaries.pm b/checks/binaries.pm
index 5870dd9bd..a0d57bc83 100644
--- a/checks/binaries.pm
+++ b/checks/binaries.pm
@@ -586,11 +586,13 @@ sub run {
             }
 
             if ($arch_hardening->{'hardening-no-bindnow'}
+                and not $built_with_golang
                 and not exists($objdump->{'FLAGS_1'}{'NOW'})) {
                 tag 'hardening-no-bindnow', $file;
             }
 
             if (    $arch_hardening->{'hardening-no-pie'}
+                and not $built_with_golang
                 and $objdump->{'ELF-TYPE'} eq 'EXEC') {
                 tag 'hardening-no-pie', $file;
             }
-- 
2.11.0