[pkg-go] Bug#866710: Bug#866710: golang-golang-x-tools FTBFS with gccgo

[Anthony Fok]

Source: golang-golang-x-tools
Version: 1:0.0~git20170629.0.1b3bb8de+ds-1
Tags: confirmed, buster, sid, pending

On Sat, Jul 1, 2017 at 12:39 AM, Adrian Bunk <bunk at debian.org> wrote:
> Source: golang-golang-x-tools
> Version: 1:0.0~git20170629.0.1b3bb8de-1
> Severity: serious
>
> https://buildd.debian.org/status/package.php?p=golang-golang-x-tools&suite=sid
>
> ...
> GOROOT=/<<PKGBUILDDIR>>/build/root GOPATH=/<<PKGBUILDDIR>>/build go install -v \
>     golang.org/x/tools/cmd/godoc
> golang.org/x/tools/cmd/godoc
> mv -v /<<PKGBUILDDIR>>/build/root/bin/godoc /<<PKGBUILDDIR>>/build/bin
> mv: cannot stat '/<<PKGBUILDDIR>>/build/root/bin/godoc': No such file or directory
> debian/rules:32: recipe for target 'override_dh_auto_build' failed
> make[1]: *** [override_dh_auto_build] Error 1

Hi Adrian!

Thank you very much for your report.  I was watching buildd and was
expecting to see errors too, initially expecting to see errors during
the tests, but it turns out an error happens much earlier than that.

It turns out that gccgo-6 (Go 1.6, default for stretch) and gccgo-7
(Go 1.8, current default for buster/sid) place the built godoc
executable in different locations, the former under GOROOT, and the
latter under GOPATH.

Hence, the workaround put in place by Martín Ferrari (tincho) to
"Reintroduce GOROOT hack to solve build failures with gccgo" in
November 2016 was essential for gccgo-6 in Stretch, but no longer
appropriate for gccgo-7.  That takes only a minute to fix though.

The next part, which I have yet to do, is to refresh
0007-Disable_tests_for_gccgo.patch and maybe
0008-Fix_tests_for_gccgo.patch, which would take a quite bit longer
(over one hour?), but unfortunately I don't have time to do so right
this moment, but I hope to work on it more during the Canada Day 150
long weekend.  :-)

Cheers,
Anthony