[pkg-go] Bug#878771: golang-github-spf13-cobra FTBFS on mips: error: redefinition of 'AF_ALG'

[Anthony Fok]

Hi Adrian and Shengjing,

On Mon, Oct 16, 2017 at 10:25 AM, Shengjing Zhu <i at zhsj.me> wrote:
> Control: reassign -1 golang-golang-x-sys
>
> On Mon, Oct 16, 2017 at 11:26 PM, Adrian Bunk <bunk at debian.org> wrote:
>> Source: golang-github-spf13-cobra
>> Version: 0.0~git20170731.0.b26b538-1
>> Severity: serious
>>
>> https://buildd.debian.org/status/fetch.php?pkg=golang-github-spf13-cobra&arch=mips&ver=0.0~git20170731.0.b26b538-2&stamp=1508109561&raw=0
>>
>> ...
>> src/golang.org/x/sys/unix/zerrors_linux_mips_mipso32.go:15:2: error: redefinition of 'AF_ALG'
>>   AF_ALG                               = 0x26
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips.go:14:2: note: previous definition of 'AF_ALG' was here
>>   AF_ALG                               = 0x26
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips_mipso32.go:16:2: error: redefinition of 'AF_APPLETALK'
>>   AF_APPLETALK                         = 0x5
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips.go:15:2: note: previous definition of 'AF_APPLETALK' was here
>>   AF_APPLETALK                         = 0x5
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips_mipso32.go:17:2: error: redefinition of 'AF_ASH'
>>   AF_ASH                               = 0x12
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips.go:16:2: note: previous definition of 'AF_ASH' was here
>>   AF_ASH                               = 0x12
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips_mipso32.go:18:2: error: redefinition of 'AF_ATMPVC'
>>   AF_ATMPVC                            = 0x8
>>   ^
>> src/golang.org/x/sys/unix/zerrors_linux_mips.go:17:2: note: previous definition of 'AF_ATMPVC' was here
>>   AF_ATMPVC                            = 0x8
>>   ^
>> ...
>>
>> I've reproduced the FTBFS with 0.0~git20170731.0.b26b538-1,
>> so that's likely triggered by some change elsewhere (gccgo 7?).
>
> It should be caused by gcc-7 7.2.0-10 which fixed #876639
> We need to revert the commits in golang/x/sys package,
> https://anonscm.debian.org/cgit/pkg-go/packages/golang-golang-x-sys.git/commit/?id=bb8f8e16490ce03ce084c8e170ea4c9e79f53ba2

Thank you for bringing this issue to my attention, and sorry for my absence.
I'll get this fixed right away.

Shengjing, thank you for pointing out the solution, otherwise I would
be at a lost too,
and thank you for filing #876639 etc. to have the proper fix
backported into gccgo-7 upstream.

Cheers,
Anthony