[pkg-go] Bug#886891: working default config in systemd (no extra backquotes)

[Antoine Beaupre]

Package: prometheus-node-exporter
Version: 0.15.2+ds-1
Severity: wishlist

It would be nice not to have to edit the
/etc/default/prometheus-node-exporter file when we use systemd. It is,
after all, the default configuration and it would seem to me better to
have a default config that works there.

I understand the desire to support other init systems, however, so
what I would propose is to find a way to make this work with both
configurations, by default. There are good ways in systemd to override
default configurations, for example:

https://askubuntu.com/a/659268

So maybe the systemd config should not use the /etc/default file,
which should be reserved for the init script. Instead, the defaults
should be written directly in the .service file and then can be
overriden in the normal way, as needed.

Why aren't those defaults set in the source anyways? It seems to me it
would be better to just have sane defaults there... 

-- System Information:
Debian Release: 9.3
  APT prefers stable
  APT policy: (500, 'stable'), (1, 'experimental'), (1, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8), LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages prometheus-node-exporter depends on:
ii  libc6         2.24-11+deb9u1
ii  systemd-sysv  232-25+deb9u1

prometheus-node-exporter recommends no packages.

prometheus-node-exporter suggests no packages.

-- Configuration Files:
/etc/default/prometheus-node-exporter changed:
ARGS="--collector.diskstats.ignored-devices=^(ram|loop|fd|(h|s|v|xv)d[a-z]|nvme\\\\d+n\\\\d+p)\\\\d+$ \
      --collector.filesystem.ignored-mount-points=^/(sys|proc|dev|run)($|/) \
      --collector.netdev.ignored-devices=^lo$ \
  --collector.ntp \
  --collector.logind \
  --collector.systemd \
      --collector.textfile.directory=/var/lib/prometheus/node-exporter"


-- no debconf information