[pkg-go] Bug#888985: Bug#888985: RFS: irtt/0.9-1 [ITP] (#888985)

[Pete Heist]

> On Feb 9, 2018, at 8:15 AM, Michael Stapelberg <stapelberg at debian.org> wrote:
> 
> On Fri, Feb 9, 2018 at 2:09 AM, Pete Heist <pete at eventide.io <mailto:pete at eventide.io>> wrote:
> 
> From the original warnings you sent I know I’ve fixed all except "I: irtt source: testsuite-autopkgtest-missing”, but a) I’m not seeing that warning and b) I’m seeing two others. So my questions are:
> 
> 1) What are your expectations for 'testsuite-autopkgtest-missing', and why am I not seeing it? There are no unit tests to run.
> 
> Did you apply the ~/.lintianrc I provided? Not doing so would explain the difference. autopkgtest is helpful even if it only compiles the package in question. Why are there no unit tests for your code? :)

Yes I did, I should have included that...

$ lintian --version
Lintian v2.5.74
$ ls -al ~/.lintianrc 
-rw-r--r-- 1 pete pete 94 Feb  7 10:25 /home/pete/.lintianrc
$ cat ~/.lintianrc 
display-info = yes
display-experimental = yes
pedantic = yes
show-overrides = no
color = auto
$

What probably explains your seeing testsuite-autopkgtest-missing and my not is that I was previously using dh-make-golang from Debian stable. The current sid version of dh-make-golang has added a "Testsuite: autopkgtest-pkg-go” line to debian/control, which likely satisfies lintian.

BTW I manually bumped compat-version from 10 to 11 and standards-version from 4.1.1 to 4.1.3 as recent changes to dh-make-golang which do this aren’t in sid yet.

As for unit tests, in short, I haven’t gotten there yet, though there’s a bit more to it than that. If you’d like, I can add a few basic ones to satisfy, otherwise they’ll go in after one more design issue is sorted out… :)

> 2) Do you care about 'debian-watch-does-not-check-gpg-signature' and 'no-upstream-changelog’? I do not sign the upstream, and the changes are in README.md, in case those should be split out...
> 
> They’re not important for the time being. Of course, if you could start signing upstream and provide a separate changelog file, that would be great.
> 
> Thanks!

Ok, I’ll take a look at these if there’s time.

Thanks, almost there… :)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180209/67376538/attachment-0001.html>