[pkg-go] Go 1.10 build/test failures
Michael Stapelberg
stapelberg at debian.org
Fri Feb 16 18:38:53 UTC 2018
I uploaded fixes for:
• golang-github-julienschmidt-httprouter
• golang-gopkg-macaroon-bakery.v2
• golang-github-asaskevich-govalidator
…and a new upstream version for golang-golang-x-oauth2, which fixes the
test failure.
…and filed upstream issues for:
• https://github.com/masterzen/winrm/issues/77
• https://github.com/tylerb/graceful/issues/106
(Help welcome! I couldn’t easily figure out the issues.)
gopherjs seems to be tied to the compiler version fairly strictly, so I
think we’ll have to update it after Go 1.10 is available.
On Thu, Feb 15, 2018 at 9:26 PM, Michael Stapelberg <stapelberg at debian.org>
wrote:
> Here’s one more, which my tooling couldn’t find before due to an unrelated
> bug:
>
> golang-github-asaskevich-govalidator
>
> --- FAIL: TestIsRequestURI (0.00s)
> validator_test.go:736: Expected IsRequestURI("irc://#channel@network")
> to be true, got false
> --- FAIL: TestIsRequestURL (0.00s)
> validator_test.go:687: Expected IsRequestURL("irc://#channel@network")
> to be true, got false
> FAIL
> FAIL github.com/asaskevich/govalidator 0.025s
>
>
> On Thu, Feb 15, 2018 at 1:14 PM, Michael Stapelberg <stapelberg at debian.org
> > wrote:
>
>> Hey,
>>
>> I did a quick rebuild of our packages with Go 1.10 (I plan to write in
>> more detail about the infrastructure I used in the next few days) and
>> noticed the following new failures:
>>
>> no longer compiles: github.com/gopherjs/gopherjs. error exit status 2
>> no longer passes tests: github.com/julienschmidt/httprouter. error exit
>> status 1
>> no longer passes tests: github.com/masterzen/winrm. error exit status 1
>> no longer passes tests: golang.org/x/oauth2. error exit status 1
>> no longer passes tests: gopkg.in/macaroon-bakery.v2. error exit status 1
>> no longer passes tests: gopkg.in/tylerb/graceful.v1. error exit status 1
>>
>> Caveat: there may be others which were broken before for unrelated
>> reasons, but this list seems like a good start.
>>
>> If anyone would like to help with proactively fixing these issues, that’d
>> be appreciated! I expect that most often, importing a new upstream version
>> entirely, or cherry-picking an upstream commit would be all that’s
>> necessary.
>>
>> Thanks in advance!
>>
>> Here are the full error logs:
>>
>> github.com/gopherjs/gopherjs. error exit status 2
>> # github.com/gopherjs/gopherjs/compiler
>> /srv/gopath/src/github.com/gopherjs/gopherjs/compiler/compiler.go:20:9:
>> undefined: ___GOPHERJS_REQUIRES_GO_VERSION_1_9___
>>
>> no longer compiles: github.com/julienschmidt/httprouter. error exit
>> status 1
>> --- FAIL: TestRouterNotFound (0.00s)
>> router_test.go:234: NotFound handling route /path/ failed:
>> Code=301, Header=map[Location:[/path] Content-Type:[text/html;
>> charset=utf-8]]
>> router_test.go:234: NotFound handling route /dir failed:
>> Code=301, Header=map[Location:[/dir/] Content-Type:[text/html;
>> charset=utf-8]]
>> router_test.go:234: NotFound handling route failed: Code=301,
>> Header=map[Location:[/] Content-Type:[text/html; charset=utf-8]]
>> router_test.go:234: NotFound handling route /PATH failed:
>> Code=301, Header=map[Location:[/path] Content-Type:[text/html;
>> charset=utf-8]]
>> router_test.go:234: NotFound handling route /DIR/ failed:
>> Code=301, Header=map[Location:[/dir/] Content-Type:[text/html;
>> charset=utf-8]]
>> router_test.go:234: NotFound handling route /PATH/ failed:
>> Code=301, Header=map[Content-Type:[text/html; charset=utf-8]
>> Location:[/path]]
>> router_test.go:234: NotFound handling route /DIR failed:
>> Code=301, Header=map[Location:[/dir/] Content-Type:[text/html;
>> charset=utf-8]]
>> router_test.go:234: NotFound handling route /../path failed:
>> Code=301, Header=map[Location:[/path] Content-Type:[text/html;
>> charset=utf-8]]
>> FAIL
>> FAIL github.com/julienschmidt/httprouter 0.016s
>>
>> github.com/masterzen/winrm. error exit status 1
>>
>> ----------------------------------------------------------------------
>> FAIL: client_test.go:89: WinRMSuite.TestRunWithString
>>
>> client_test.go:100:
>> c.Assert(stdout, Equals, "That's all folks!!!")
>> ... obtained string = "That's all folks!!!\x00\x00\x00\x00\x00\x
>> 00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\
>> x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"
>> ... expected string = "That's all folks!!!"
>>
>> OOPS: 36 passed, 1 FAILED
>> --- FAIL: Test (5.03s)
>> FAIL
>> FAIL github.com/masterzen/winrm 5.041s
>>
>> golang.org/x/oauth2. error exit status 1
>> ok golang.org/x/oauth2 (cached)
>> ? golang.org/x/oauth2/amazon [no test files]
>> ? golang.org/x/oauth2/bitbucket [no test files]
>> ok golang.org/x/oauth2/clientcredentials (cached)
>> ? golang.org/x/oauth2/facebook [no test files]
>> ? golang.org/x/oauth2/fitbit [no test files]
>> ? golang.org/x/oauth2/foursquare [no test files]
>> ? golang.org/x/oauth2/github [no test files]
>> ? golang.org/x/oauth2/heroku [no test files]
>> ? golang.org/x/oauth2/hipchat [no test files]
>> --- FAIL: TestRetrieveTokenBustedNoSecret (0.00s)
>> token_test.go:42: RetrieveToken = unexpected end of JSON input;
>> want no error
>> --- FAIL: TestRetrieveTokenWithContexts (0.00s)
>> token_test.go:91: RetrieveToken (with background context) =
>> unexpected end of JSON input; want no error
>> FAIL
>> FAIL golang.org/x/oauth2/internal 0.004s
>> ok golang.org/x/oauth2/jws (cached)
>> ok golang.org/x/oauth2/jwt (cached)
>> ? golang.org/x/oauth2/linkedin [no test files]
>> ? golang.org/x/oauth2/mediamath [no test files]
>> ? golang.org/x/oauth2/microsoft [no test files]
>> ? golang.org/x/oauth2/odnoklassniki [no test files]
>> ? golang.org/x/oauth2/paypal [no test files]
>> ? golang.org/x/oauth2/slack [no test files]
>> ? golang.org/x/oauth2/uber [no test files]
>> ? golang.org/x/oauth2/vk [no test files]
>> ? golang.org/x/oauth2/yandex [no test files]
>>
>> gopkg.in/macaroon-bakery.v2. error exit status 1
>> ok gopkg.in/macaroon-bakery.v2/bakery (cached)
>> ok gopkg.in/macaroon-bakery.v2/bakery/checkers (cached)
>> ok gopkg.in/macaroon-bakery.v2/bakery/identchecker (cached)
>> ? gopkg.in/macaroon-bakery.v2/bakery/internal/macaroonpb [no test
>> files]
>> ok gopkg.in/macaroon-bakery.v2/bakery/mgorootkeystore (cached)
>> ok gopkg.in/macaroon-bakery.v2/bakerytest (cached)
>>
>> ----------------------------------------------------------------------
>> FAIL: keyring_test.go:157: KeyringSuite.TestThirdPartyInf
>> oForLocationReturnsStatusInternalServerError
>>
>> keyring_test.go:164:
>> c.Assert(err, gc.ErrorMatches,
>> fmt.Sprintf(`Get %s/discharge/info: cannot unmarshal error
>> response \(status 500 Internal Server Error\): unexpected content type
>> text/plain; want application/json; content: `, ts.URL))
>> ... error string = "Get http://127.0.0.1:39547/discharge/info: cannot
>> unmarshal error response (status 500 Internal Server Error): unexpected
>> content type \"\"; want application/json; content: \"\""
>> ... regex string = "Get http://127.0.0.1:39547/discharge/info: cannot
>> unmarshal error response \\(status 500 Internal Server Error\\): unexpected
>> content type text/plain; want application/json; content: "
>>
>> OOPS: 45 passed, 1 FAILED
>> --- FAIL: TestPackage (1.95s)
>> FAIL
>> FAIL gopkg.in/macaroon-bakery.v2/httpbakery 1.956s
>>
>> gopkg.in/tylerb/graceful.v1. error exit status 1
>> 2018/02/15 11:02:24 http: TLS handshake error from [::1]:53422: remote
>> error: tls: bad certificate
>> --- FAIL: TestHTTP2ListenAndServeTLS (0.10s)
>> http2_test.go:48: Error encountered while connecting to test
>> server: Get https://localhost:9654: tls: failed to parse certificate
>> from server: x509: cannot parse dnsName "Test Intermediate CA"
>> 2018/02/15 11:02:24 http: TLS handshake error from [::1]:53424: remote
>> error: tls: bad certificate
>> --- FAIL: TestHTTP2ListenAndServeTLSConfig (0.10s)
>> http2_test.go:48: Error encountered while connecting to test
>> server: Get https://localhost:9654: tls: failed to parse certificate
>> from server: x509: cannot parse dnsName "Test Intermediate CA"
>> FAIL
>> FAIL gopkg.in/tylerb/graceful.v1 4.668s
>>
>>
>> --
>> Best regards,
>> Michael
>>
>
>
>
> --
> Best regards,
> Michael
>
--
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180216/c46298cb/attachment-0001.html>
More information about the Pkg-go-maintainers
mailing list