[pkg-go] Call for review: golang-github-containerd-cgroups

[Michael Stapelberg]

On Tue, Feb 20, 2018 at 11:35 AM, Arnaud <arnaud.rebillout at collabora.com>
wrote:

> Dear Go Packaging Team,
>
> here are the url related to this package:
>
> https://salsa.debian.org/go-team/packages/golang-github-containerd-cgroups
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890807
>
> The test file paths_test.go fails in a chroot, as it requires the
> cgroups hierarchy to be mounted. I tackled that by disabling all the
> tests when the cgroup hierarchy is not mounted.
>

Could you move this check into the relevant test(s)? See
https://golang.org/pkg/testing/#T.Skip. Then, please contribute it upstream
so that others can benefit from this fix as well.

This doesn’t need to block uploading the package, though, and it does look
good aside from the tests issue.

Let me know if you’d like me to upload now, or if you want to make the
change first.


>
> Best regards,
>
>   Arnaud
>



-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180221/cddaa4a4/attachment.html>