[pkg-go] Call for review - containerd and dependencies

Fri Feb 23 10:10:59 UTC 2018

I can’t have a look at the individual packages right now (but might have
some time in the evening/over the weekend), but here’s some quick feedback:

On Fri, Feb 23, 2018 at 11:01 AM, Arnaud <arnaud.rebillout at collabora.com>
wrote:

> Hello Go Packaging Team,
>
> I reached a milestone, I managed to get an up-to-date containerd package!
>

Congratulations!

>
> I changed a bit my workflow and worked on my "personal staging area" in
> salsa, ie `salsa.debian.org/elboulangero-guest`, rather than directly
> in `salsa.debian.org/go-team`. I find it more convenient, I can mess
> around without bothering anyone.
>
> I also packaged several packages before asking a review, as I don'twant
> to waste your time with my iterations, and ask you to review thingsthat
> in the end are not needed.
>
> So now, the bad news is that there's quite a bunch of packages to review,
> but the good news is that if it's all good, then we have the latest
> containerd in Debian, and then we're closer to having docker packaged
> as well (I can't say exactly *how close* though...) !
>
> So here comes the review list, with links and comments !
>
>
>
> BUMPED PACKAGES
> ---------------
>
> I forked the packages from `anonscm.debian.org` into my personal staging
> area `salsa.debian.org/elboulangero-guest`.
>
> I don't think I have write access to `anonscm.debian.org`, although I
> didn't try. I just don't want to mess up so it's more convenient to use
> my personal namespace on salsa.
>

You are a pkg-go member on alioth, so you do have write access.

>
> I didn't touch the control urls in `debian/control`, so I believe that my
> changes can be merged into the anonscm.debian.org repository without any
> drama. Well, I hope :)
>
> #### containerd
> <https://salsa.debian.org/elboulangero-guest/containerd>
> - There's a lintian warning about package-contains-vcs-control-file, but
> until
>   now I didn't find the right way to remove a file from installation. I
> guess
>   `override_dh_auto_install` is the way to go. Any hint welcome here.
>

Which file specifically is affected? The Files-Excluded directive in
debian/copyright is a good way to exclude files.

> - As for testing the thing really, I didn't go far yet, I just launched
>   the binary, the log messages that appeared looked healthy enough, and
>   that's all for now.
>
> #### golang-github-docker-go-events
> <https://salsa.debian.org/elboulangero-guest/golang-
> github-docker-go-events>
>
> #### golang-github-docker-go-metrics
> <https://salsa.debian.org/elboulangero-guest/golang-
> github-docker-go-metrics>
>
> #### golang-github-opencontainers-image-spec
> <https://salsa.debian.org/elboulangero-guest/golang-
> github-opencontainers-image-spec>
> - I noticed only after doing all the work that Michael Stapelberg was
>   working on this package lately. I hope I don't duplicate the work.
> - The 3 last commits are probably not that good, please advise and I'll
>   fix it.
>
> #### golang-github-prometheus-client-golang
> <https://salsa.debian.org/elboulangero-guest/golang-
> github-prometheus-client-golang>
>
>
>
> NEW PACKAGES
> ------------
>
> These packages live in my personal staging area, that is:
> `salsa.debian.org/elboulangero-guest`. However the control urls are set to
> `salsa.debian.org/go-team`, so I believe it's just a matter of moving the
> repository there if you give me your ack.
>
> #### continuity
> <https://salsa.debian.org/elboulangero-guest/continuity>
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890983>
> - Produces continuity and golang-github-containerd-continuity-dev.
>   I looked at the existing packages docker and docker-containerd for
>   guidance.
> - I ran the series of test described at
> <https://github.com/containerd/continuity>,
>   everything went fine.
>
> #### golang-gogottrpc
> <https://salsa.debian.org/elboulangero-guest/golang-gogottrpc>
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890958>
> - Produces golang-gogottrpc and golang-github-stevvooe-ttrpc-dev.
>   I looked at the existing package golang-gogoprotobuf for guidance.
> - Patch and issues submitted upstream.
>
> #### golang-github-containerd-btrfs
> <https://salsa.debian.org/elboulangero-guest/golang-
> github-containerd-btrfs>
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989>
> - I disabled the test to avoid installing a btrfs-test binary, plus I
> think the
>   test failed for some reason, I'm not sure to remember though...
>

To avoid installing a binary, can you use the DH_GOLANG_EXCLUDES option
please? See
https://manpages.debian.org/testing/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html

Also, please add a comment stating why precisely the tests are disabled,
and what needs to change so that we can re-enable them.

>
> #### golang-github-containerd-typeurl
> <https://salsa.debian.org/elboulangero-guest/golang-
> github-containerd-typeurl>
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181>
> - Patch submitted upstream
>
> #### golang-github-dmcgowan-go-tar
> <https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar
> >
> <https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960>
> - This one was a tricky one, please read the commit messages for details.
>
>
>
> GENERAL QUESTIONS
> -----------------
>
> I see that most binaries come with the lintian warning
> `statically-linked-binary`, I guess it's just the way it works in the
> go world. Should I just add a lintian override ?
>

lintian does not emit the statically-linked-binary tag for Go packages. Can
you point me to a specific example where you see it please?

>
> In the `-dev` packages, is `${shlibs:Depends}` needed ? During the builds
> I see `unknown substitution variable ${shlibs:Depends}` passing by.
>

The messages implies it’s not required. I’m not entirely sure, but would
suggest removing it for now.

>
> In the `-dev` packages, do we really need to copy-paste all the
> dependencies from the source package ?
>

Yes. They differ in some cases, for example when code generation needs more
dependencies than the actual compilation/test (in which case the extra
dependencies show up only in Build-Depends, not Depends).

>
>
>
> Thanks for reading, waiting for your feedback.
>
> Best regards,
>
>   Arnaud
>

-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180223/58684f80/attachment-0001.html>