[pkg-go] RFS: golang-github-smartystreets-gunit

Michael Stapelberg stapelberg at debian.org
Mon Apr 9 06:44:52 UTC 2018


The package looks good, but it might be good to remove the NOTE in the
Expat License entry in debian/copyright:

 NOTE: Various optional and subordinate components carry their own licensing
 requirements and restrictions.  Use of those components is subject to the
terms
 and conditions outlined the respective license of each component.

I’m suggesting to remove it because we don’t vendor in Debian, so this
doesn’t apply. In case I’m misunderstanding what components the note refers
to, and it means parts of the source itself, not just vendored
dependencies, that would be even more reason to remove it, because those
would need to be listed explicitly in debian/copyright.

The copyright statement itself also looked insufficient to me, but I can’t
find a more specific identifier than “SmartyStreets”. I had hoped to find
something like SmartyStreets Inc. or LLC to convey that this is a company
(as opposed to a GitHub username), but couldn’t find anything on their
website. Let’s hope that ftp-master is okay with the copyright as-is.

On Sun, Apr 8, 2018 at 11:11 AM, <rajudev at disroot.org> wrote:

> Hello Go Team,
> I have prepared the packaging for https://github.com/smartystreets/gunit
> and have uploaded to Salsa.
> Please take a look at the package, review and upload it.
>
> https://salsa.debian.org/go-team/packages/golang-github-
> smartystreets-gunit
>
> Usually I send RFS mails to pkg-go list, should I also start CCing
> debian-devel list?
>
> Thanks,
> Raju Devidas
>
> _______________________________________________
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers
>



-- 
Best regards,
Michael
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180409/80fdf560/attachment.html>


More information about the Pkg-go-maintainers mailing list