[pkg-go] RFS: golang-github-smartystreets-gunit
stapelberg at debian.org
Tue Apr 10 07:25:47 BST 2018
I recommend changing the copyright to “SmartyStreets, LLC”, which is
clearer for the reader and consistent with what we already have in the
On Mon, Apr 9, 2018 at 10:01 PM, Raju Devidas <rajudev at disroot.org> wrote:
> In Between.
> On 04/09/2018 12:14 PM, Michael Stapelberg wrote:
> The package looks good, but it might be good to remove the NOTE in the
> Expat License entry in debian/copyright:
> Thanks a lot for taking out the time to review the packages.
> NOTE: Various optional and subordinate components carry their own
> requirements and restrictions. Use of those components is subject to the
> and conditions outlined the respective license of each component.
> I’m suggesting to remove it because we don’t vendor in Debian, so this
> doesn’t apply. In case I’m misunderstanding what components the note refers
> to, and it means parts of the source itself, not just vendored
> dependencies, that would be even more reason to remove it, because those
> would need to be listed explicitly in debian/copyright.
> Dropping the note.
> The copyright statement itself also looked insufficient to me, but I can’t
> find a more specific identifier than “SmartyStreets”. I had hoped to find
> something like SmartyStreets Inc. or LLC to convey that this is a company
> (as opposed to a GitHub username), but couldn’t find anything on their
> website. Let’s hope that ftp-master is okay with the copyright as-is.
> I looked at a few other packages by smartystreets which are already in
> Debian main. Including
> goconvey https://tracker.debian.org/pkg/golang-github-
> assertions https://tracker.debian.org/pkg/golang-github-
> and both of them seem to refer to smarty streets as SmartyStreets, LLC
> even the upstream source code license mentions it as SmartyStreets, LLC
> It is just in my case the upstream license just has the name as
> Should I just keep the name as is in the upstream or should there be no
> issues adding the LLC part?
> On Sun, Apr 8, 2018 at 11:11 AM, <rajudev at disroot.org> wrote:
>> Hello Go Team,
>> I have prepared the packaging for https://github.com/smartystreets/gunit
>> and have uploaded to Salsa.
>> Please take a look at the package, review and upload it.
>> Usually I send RFS mails to pkg-go list, should I also start CCing
>> debian-devel list?
>> Raju Devidas
>> Pkg-go-maintainers mailing list
>> Pkg-go-maintainers at lists.alioth.debian.org
> Best regards,
> Raju Devidas
> XMPP/Jabber: rajudev(at)disroot.org
> Pkg-go-maintainers mailing list
> Pkg-go-maintainers at lists.alioth.debian.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pkg-go-maintainers