[pkg-go] Bug#895623: golang-github-juju-testing: dep8 test failure with mongodb 3.6

[Robie Basak]

Package: golang-github-juju-testing
Version: 0.0~git20170608.2fe0e88-3
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu bionic ubuntu-patch

In Ubuntu, the attached patch was applied to achieve the following:

I'm bumping up to mongodb 3.6, which isn't currently in Debian but I
expect will happen sooner or later. At this point, you'll need this
package updated to a new upstream, or you'll need to cherry-pick the
same patch, to fix dep8.

I will separately submit my mongodb 3.6 updates to Debian.

Thanks for considering the patch.

*** /tmp/tmpOdgl3i/golang-github-juju-testing_0.0~git20170608.2fe0e88-3ubuntu1.debdiff
diff -Nru golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/mongodb-3.6 golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/mongodb-3.6
--- golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/mongodb-3.6	1970-01-01 01:00:00.000000000 +0100
+++ golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/mongodb-3.6	2018-04-13 16:47:11.000000000 +0100
@@ -0,0 +1,39 @@
+From 1f2396685494ccf2c5079936561a70652ef78111 Mon Sep 17 00:00:00 2001
+From: John Arbash Meinel <john at arbash-meinel.com>
+Date: Mon, 2 Apr 2018 15:18:23 +0400
+Subject: [PATCH] Changes to support Mongo 3.6.
+
+Don't drop the 'admin' database, and we don't actually need to pass
+`--nohttpinterface`.
+
+In 3.6, there is no '--httpinterface' that you could pass, so there is
+also not its negation. But since it isn't the default, we don't actually
+ever need to pass it.
+
+Origin: upstream, https://github.com/juju/testing/commit/1f2396685494ccf2c5079936561a70652ef78111
+Last-Update: 2018-04-13
+---
+ mgo.go | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+diff --git a/mgo.go b/mgo.go
+index c128747..de668ca 100644
+--- a/mgo.go
++++ b/mgo.go
+@@ -230,7 +230,6 @@ func (inst *MgoInstance) run() error {
+ 		"--nssize", "1",
+ 		"--noprealloc",
+ 		"--smallfiles",
+-		"--nohttpinterface",
+ 		"--oplogSize", "10",
+ 		"--ipv6",
+ 		"--setParameter", "enableTestCommands=1",
+@@ -744,7 +743,7 @@ func (inst *MgoInstance) Reset() error {
+ 	logger.Infof("reset successfully reset admin password")
+ 	for _, name := range dbnames {
+ 		switch name {
+-		case "local", "config":
++		case "local", "config", "admin":
+ 			// don't delete these
+ 			continue
+ 		}
diff -Nru golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/series golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/series
--- golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ golang-github-juju-testing-0.0~git20170608.2fe0e88/debian/patches/series	2018-04-13 16:46:26.000000000 +0100
@@ -0,0 +1 @@
+mongodb-3.6
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-go-maintainers/attachments/20180413/1e928407/attachment.sig>