[pkg-go] Bug#900597: golang-github-prometheus-client-golang/0.9.0~pre1+git20180417.82f5ff1-2 breaks golang-github-docker-go-metrics

[Paul Gevers]

Source: golang-github-prometheus-client-golang
Version: 0.9.0~pre1+git20180417.82f5ff1-2
Severity: serious
Justification: breaks reverse dependency
Affects: src:golang-github-docker-go-metrics
User: debian-ci at lists.debian.org
Usertags: breaks

Version 0.9.0~pre1+git20180417.82f5ff1-2 of
golang-github-prometheus-client-golang causes FTBFS of
golang-github-docker-go-metrics. This bug is to block migration of
golang-github-prometheus-client-golang until
golang-github-docker-go-metrics has been updated to cope with the new
version.

golang-github-prometheus-client-golang could (and in my opinion should)
declare a "Breaks: golang-github-docker-go-metrics (<=
0.0~git20170503.0.d466d4f-1)" relation (or better, if the new version is
-2 a "Breaks: golang-github-docker-go-metrics (<<
0.0~git20170503.0.d466d4f-2~)").

On 01-06-18 02:33, Martín Ferrari wrote:
>> On 24-05-18 13:48, Paul Gevers wrote:
> 
>> It looks like to me that this is causing FTBFS (as seen on
>> reproducibility¹), so I guess that golang-github-docker-go-metrics
>> maintainers would want to create an RC bug against the
>> golang-github-prometheus-client-golang to prevent it from migrating
>> until the FTBFS is fixed.
> 
> I am not that surprised, as these golang APIs are very unstable. I
> thought this had passed our regresion tests, but I guess I am still not
> used to the system :-)
> 
> I took a quick look, and it indeed seems to be an incompatible API
> change. The problem is, there is no way to fix this unless we tried to
> change sonames everytime this happens (which is pretty often and without
> warning). It was merged here:
> https://github.com/prometheus/client_golang/pull/285/
> 
> Luckily, docker has already fixed it, so an update of the rdep should
> fix this issue: https://github.com/docker/go-metrics/issues/12
> 
> I will take a look into it next week as I will be offline for a few
> days, but if it is deemed that this needs to be blocked, please go ahead
> with the RC bug.

Paul



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-go-maintainers/attachments/20180601/4bc7860f/attachment.sig>