[pkg-go] Bug#901223: gitaly: FTBFS: prometheus.Observer does not implement prometheus.Histogram

[Andreas Beckmann]

Source: gitaly
Version: 0.96.1+debian-4
Severity: serious
Justification: fails to build from source (but built successfully in the past)

Hi,

gitaly/experimental FTBFS:

https://buildd.debian.org/status/fetch.php?pkg=gitaly&arch=amd64&ver=0.96.1%2Bdebian-4&stamp=1528128434&raw=0

...
gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/testpb
gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler
gitlab.com/gitlab-org/gitaly/internal/helper/housekeeping
# gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler
src/gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/metrics.go:109:13: cannot use histogramVec.WithLabelValues(serviceName, methodName) (type prometheus.Observer) as type prometheus.Histogram in assignment:
	prometheus.Observer does not implement prometheus.Histogram (missing Collect method)
gitlab.com/gitlab-org/gitaly/vendor/google.golang.org/grpc/reflection
github.com/stretchr/testify/require
gitlab.com/gitlab-org/gitaly/internal/helper/fieldextractors
gitlab.com/gitlab-org/gitaly/client
gitlab.com/gitlab-org/gitaly/cmd/gitaly-ssh
dh_auto_build: cd obj-x86_64-linux-gnu && go install -gcflags=\"-trimpath=/<<BUILDDIR>>/gitaly-0.96.1\+debian/obj-x86_64-linux-gnu/src\" -asmflags=\"-trimpath=/<<BUILDDIR>>/gitaly-0.96.1\+debian/obj-x86_64-linux-gnu/src\" -v -p 4 -ldflags "-X gitlab.com/gitlab-org/gitaly/internal/version.version=0.96.1+debian" gitlab.com/gitlab-org/gitaly/auth gitlab.com/gitlab-org/gitaly/client gitlab.com/gitlab-org/gitaly/cmd/gitaly gitlab.com/gitlab-org/gitaly/cmd/gitaly-ssh gitlab.com/gitlab-org/gitaly/internal/archive gitlab.com/gitlab-org/gitaly/internal/command gitlab.com/gitlab-org/gitaly/internal/config gitlab.com/gitlab-org/gitaly/internal/connectioncounter gitlab.com/gitlab-org/gitaly/internal/diff gitlab.com/gitlab-org/gitaly/internal/git gitlab.com/gitlab-org/gitaly/internal/git/alternates gitlab.com/gitlab-org/gitaly/internal/git/catfile gitlab.com/gitlab-org/gitaly/internal/git/log gitlab.com/gitlab-org/gitaly/internal/helper gitlab.com/gitlab-org/gitaly/internal/helper/fieldextractors gitlab.com/gitlab-org/gitaly/internal/helper/housekeeping gitlab.com/gitlab-org/gitaly/internal/helper/lines gitlab.com/gitlab-org/gitaly/internal/linguist gitlab.com/gitlab-org/gitaly/internal/logsanitizer gitlab.com/gitlab-org/gitaly/internal/middleware/cancelhandler gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/testpb gitlab.com/gitlab-org/gitaly/internal/middleware/metadatahandler gitlab.com/gitlab-org/gitaly/internal/middleware/panichandler gitlab.com/gitlab-org/gitaly/internal/middleware/sentryhandler gitlab.com/gitlab-org/gitaly/internal/rubyserver gitlab.com/gitlab-org/gitaly/internal/rubyserver/balancer gitlab.com/gitlab-org/gitaly/internal/server gitlab.com/gitlab-org/gitaly/internal/server/auth gitlab.com/gitlab-org/gitaly/internal/service gitlab.com/gitlab-org/gitaly/internal/service/blob gitlab.com/gitlab-org/gitaly/internal/service/commit gitlab.com/gitlab-org/gitaly/internal/service/conflicts gitlab.com/gitlab-org/gitaly/internal/service/diff gitlab.com/gitlab-org/gitaly/internal/service/namespace gitlab.com/gitlab-org/gitaly/internal/service/notifications gitlab.com/gitlab-org/gitaly/internal/service/operations gitlab.com/gitlab-org/gitaly/internal/service/ref gitlab.com/gitlab-org/gitaly/internal/service/remote gitlab.com/gitlab-org/gitaly/internal/service/repository gitlab.com/gitlab-org/gitaly/internal/service/server gitlab.com/gitlab-org/gitaly/internal/service/smarthttp gitlab.com/gitlab-org/gitaly/internal/service/ssh gitlab.com/gitlab-org/gitaly/internal/service/wiki gitlab.com/gitlab-org/gitaly/internal/storage gitlab.com/gitlab-org/gitaly/internal/supervisor gitlab.com/gitlab-org/gitaly/internal/supervisor/test-scripts gitlab.com/gitlab-org/gitaly/internal/tempdir gitlab.com/gitlab-org/gitaly/internal/testhelper gitlab.com/gitlab-org/gitaly/internal/version gitlab.com/gitlab-org/gitaly/streamio returned exit code 2
make[1]: *** [debian/rules:23: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/gitaly-0.96.1+debian'
make: *** [debian/rules:14: build-arch] Error 2


Andreas