[pkg-go] Code review: golang-github-danverbraganza-varcaser

[Tong Sun]

Hi all,

Thanks to Anthony help. I've fixed all known problem to the first Go
package I'm packing.

Would someone do a final check on it before I upload it as new please?

Especially, Clément & Martín,

Would you check that I'm following the new workflow correctly please,
as Anthony himself is still using the old workflow.

Again,
The project is at
https://salsa.debian.org/go-team/packages/golang-github-danverbraganza-varcaser

and my build log is posted at
http://paste.debian.net/plain/1030394

Thanks

On Thu, Jun 21, 2018 at 8:12 AM Anthony Fok wrote:
>
> Hi Tong,
>
> On Sun, Jun 17, 2018 at 8:15 AM, Tong Sun wrote:
> > Finally! I was able to make my first build successfully!
>
> Congratulations!
>
> > This is my first Go package, and it now builds (kind of). Please
> > review it for me before I make my next step.
> >
> > The project is at
> > https://salsa.debian.org/go-team/packages/golang-github-danverbraganza-varcaser
> > and my changes are at
> > https://salsa.debian.org/go-team/packages/golang-github-danverbraganza-varcaser/commits/debian/sid
> >
> > Known problem (that I don't know how to fix)
> >
> >
> > - gbp clone it is problematic:
> >
> > $ gbp clone git at salsa.debian.org:go-team/packages/golang-github-danverbraganza-varcaser.git
> > gbp:info: Cloning from
> > 'git at salsa.debian.org:go-team/packages/golang-github-danverbraganza-varcaser.git'
> > gbp:error: Git command failed: Error running git checkout: error:
> > pathspec 'master' did not match any file(s) known to git.
>
> This problem perplexed me too and I spent like two hours reading about
> it and experimenting.
> It turns out that