[pkg-go] Bug#902468: golang-github-mwitkow-go-conntrack: FTBFS in buster/sid (failing tests)

[Santiago Vila]

Package: src:golang-github-mwitkow-go-conntrack
Version: 0.0~git20161129.cc309e4-2
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_autoreconf -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
dh_auto_configure: "github.com/mwitkow/go-conntrack" is already installed. Please check for circular dependencies.

   dh_auto_build -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go install -gcflags=\"-trimpath=/<<BUILDDIR>>/golang-github-mwitkow-go-conntrack-0.0\~git20161129.cc309e4/obj-x86_64-linux-gnu/src\" -asmflags=\"-trimpath=/<<BUILDDIR>>/golang-github-mwitkow-go-conntrack-0.0\~git20161129.cc309e4/obj-x86_64-linux-gnu/src\" -v -p 1 github.com/mwitkow/go-conntrack github.com/mwitkow/go-conntrack/connhelpers
github.com/beorn7/perks/quantile
github.com/golang/protobuf/proto
github.com/prometheus/client_model/go
github.com/matttproud/golang_protobuf_extensions/pbutil
github.com/prometheus/common/internal/bitbucket.org/ww/goautoneg
github.com/prometheus/common/model
github.com/prometheus/common/expfmt
github.com/prometheus/procfs/internal/util
github.com/prometheus/procfs/nfs
github.com/prometheus/procfs/xfs
github.com/prometheus/procfs
github.com/prometheus/client_golang/prometheus
golang.org/x/net/internal/timeseries
golang.org/x/net/trace
github.com/mwitkow/go-conntrack
github.com/mwitkow/go-conntrack/connhelpers
   dh_auto_test -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go test -vet=off -v -p 1 github.com/mwitkow/go-conntrack github.com/mwitkow/go-conntrack/connhelpers
=== RUN   TestDialerWrapper
=== RUN   TestDialerWrapper/TestDialerMetricsAreNotPreregisteredWithMonitoringOff
=== RUN   TestDialerWrapper/TestDialerMetricsArePreregistered
=== RUN   TestDialerWrapper/TestDialerRefusedFailure
=== RUN   TestDialerWrapper/TestDialerResolutionFailure
=== RUN   TestDialerWrapper/TestDialerUnderNormalConnection
=== RUN   TestDialerWrapper/TestDialerWithContextName
--- PASS: TestDialerWrapper (0.12s)
    --- PASS: TestDialerWrapper/TestDialerMetricsAreNotPreregisteredWithMonitoringOff (0.01s)
    --- PASS: TestDialerWrapper/TestDialerMetricsArePreregistered (0.02s)
    --- PASS: TestDialerWrapper/TestDialerRefusedFailure (0.01s)
    --- PASS: TestDialerWrapper/TestDialerResolutionFailure (0.04s)
    --- PASS: TestDialerWrapper/TestDialerUnderNormalConnection (0.02s)
    --- PASS: TestDialerWrapper/TestDialerWithContextName (0.01s)
	dialer_test.go:186: stopped http.Server at: 127.0.0.1:46241
=== RUN   TestListenerTestSuite
=== RUN   TestListenerTestSuite/TestDialerTracingCapturedInPage
=== RUN   TestListenerTestSuite/TestMonitoringNormalConns
=== RUN   TestListenerTestSuite/TestTracingNormalComms
=== RUN   TestListenerTestSuite/TestTrackingMetricsPreregistered
--- FAIL: TestListenerTestSuite (0.05s)
    --- PASS: TestListenerTestSuite/TestDialerTracingCapturedInPage (0.01s)
    --- FAIL: TestListenerTestSuite/TestMonitoringNormalConns (0.01s)
    	listener_test.go:81: 
    			Error Trace:	listener_test.go:81
    			Error:      	Not equal: 
    			            	expected: 2
    			            	actual  : 1
    			Test:       	TestListenerTestSuite/TestMonitoringNormalConns
    			Messages:   	the closed conn counter must be incremented after connection was closed
    --- PASS: TestListenerTestSuite/TestTracingNormalComms (0.01s)
    --- PASS: TestListenerTestSuite/TestTrackingMetricsPreregistered (0.01s)
	listener_test.go:97: stopped http.Server at: 127.0.0.1:41893
FAIL
FAIL	github.com/mwitkow/go-conntrack	0.180s
?   	github.com/mwitkow/go-conntrack/connhelpers	[no test files]
dh_auto_test: cd obj-x86_64-linux-gnu && go test -vet=off -v -p 1 github.com/mwitkow/go-conntrack github.com/mwitkow/go-conntrack/connhelpers returned exit code 1
debian/rules:6: recipe for target 'build-indep' failed
make: *** [build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The above is how the build ends in my autobuilder and it's not
necessarily the relevant part.

The failure is not, however, related to using dpkg-buildpackage -A,
as it also fails in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-github-mwitkow-go-conntrack.html

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the page for this package.

Thanks.