[pkg-go] Bug#902563: golang-github-shirou-gopsutil: FTBFS in machines not having virtualization support (?)

[Santiago Vila]

Package: src:golang-github-shirou-gopsutil
Version: 2.18.02-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster with "dpkg-buildpackage -A"
but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_autoreconf -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
   dh_auto_build -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go install -gcflags=\"-trimpath=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src\" -asmflags=\"-trimpath=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src\" -v -p 1 github.com/shirou/gopsutil github.com/shirou/gopsutil/cpu github.com/shirou/gopsutil/disk github.com/shirou/gopsutil/docker github.com/shirou/gopsutil/host github.com/shirou/gopsutil/internal/common github.com/shirou/gopsutil/load github.com/shirou/gopsutil/mem github.com/shirou/gopsutil/net github.com/shirou/gopsutil/process
github.com/shirou/gopsutil
github.com/shirou/gopsutil/internal/common
github.com/shirou/gopsutil/cpu
golang.org/x/sys/unix
github.com/shirou/gopsutil/disk
github.com/shirou/gopsutil/docker

[... snipped ...]

=== RUN   TestVirtualization
--- FAIL: TestVirtualization (0.00s)
        host_test.go:137: Virtualization() retuns empty system or role:  , 
        host_test.go:140: Virtualization(): , 
=== RUN   TestKernelVersion
--- PASS: TestKernelVersion (0.00s)
        host_test.go:152: KernelVersion(): 4.9.0-6-amd64
FAIL
FAIL    github.com/shirou/gopsutil/host 0.020s

[...]

--- PASS: Test_OpenFiles (0.00s)
=== RUN   Test_Kill
--- PASS: Test_Kill (0.10s)
PASS
ok  	github.com/shirou/gopsutil/process	0.314s
dh_auto_test: cd obj-x86_64-linux-gnu && go test -vet=off -v -p 1 github.com/shirou/gopsutil github.com/shirou/gopsutil/cpu github.com/shirou/gopsutil/disk github.com/shirou/gopsutil/docker github.com/shirou/gopsutil/host github.com/shirou/gopsutil/internal/common github.com/shirou/gopsutil/load github.com/shirou/gopsutil/mem github.com/shirou/gopsutil/net github.com/shirou/gopsutil/process returned exit code 1
debian/rules:10: recipe for target 'build-indep' failed
make: *** [build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The failure is not related to using "dpkg-buildpackage -A" at all, as
a similar error happens here in reproducible builds in the i386 architecture:

https://tests.reproducible-builds.org/debian/rb-pkg/buster/i386/golang-github-shirou-gopsutil.html

I don't even understand the purpose of the test. Following a common
reasoning from Chris Lamb in similar cases: Does this failing test
means the program will not work properly on machines not having
virtualization support? (I don't really think so).

Thanks.