[pkg-go] Bug#903331: golang-golang-x-net-dev: FTBFS in buster/sid (dh_installdocs: Cannot find "README")

[Santiago Vila]

Package: src:golang-golang-x-net-dev
Version: 1:0.0+git20180124.0ed95ab+dfsg-1
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang --builddirectory=build
   dh_update_autotools_config -i -O--buildsystem=golang -O--builddirectory=build
   debian/rules override_dh_auto_configure
make[1]: Entering directory '/<<BUILDDIR>>/golang-golang-x-net-dev-0.0+git20180124.0ed95ab+dfsg'
dh_auto_configure -O--buildsystem=golang
	install -d build
	Copy idna/idna_test.go -> build/src/golang.org/x/net/idna/idna_test.go
	Copy idna/idna.go -> build/src/golang.org/x/net/idna/idna.go
	Copy idna/example_test.go -> build/src/golang.org/x/net/idna/example_test.go
	Copy idna/punycode_test.go -> build/src/golang.org/x/net/idna/punycode_test.go
	Copy idna/trie.go -> build/src/golang.org/x/net/idna/trie.go
	Copy idna/trieval.go -> build/src/golang.org/x/net/idna/trieval.go
	Copy idna/tables.go -> build/src/golang.org/x/net/idna/tables.go

[... snipped ...]

=== RUN   TestParseAuthority
--- PASS: TestParseAuthority (0.00s)
=== RUN   TestClose
--- PASS: TestClose (0.00s)
=== RUN   TestOrigin
--- PASS: TestOrigin (0.00s)
=== RUN   TestCtrlAndData
--- PASS: TestCtrlAndData (0.00s)
=== RUN   TestCodec_ReceiveLimited
--- PASS: TestCodec_ReceiveLimited (0.00s)
	websocket_test.go:629: payload #0 (size 1024, exceeds limit: false)
	websocket_test.go:629: payload #1 (size 2048, exceeds limit: false)
	websocket_test.go:629: payload #2 (size 4096, exceeds limit: true)
	websocket_test.go:629: payload #3 (size 2048, exceeds limit: false)
PASS
ok  	golang.org/x/net/websocket	0.012s
=== RUN   TestValidToken
--- PASS: TestValidToken (0.00s)
=== RUN   TestSeparatorReplacement
--- PASS: TestSeparatorReplacement (0.00s)
=== RUN   TestInvalidToken
--- PASS: TestInvalidToken (0.00s)
=== RUN   TestValidateBadData
--- PASS: TestValidateBadData (0.00s)
PASS
ok  	golang.org/x/net/xsrftoken	0.001s
make[1]: Leaving directory '/<<BUILDDIR>>/golang-golang-x-net-dev-0.0+git20180124.0ed95ab+dfsg'
 fakeroot debian/rules binary-indep
dh binary-indep --buildsystem=golang --with=golang --builddirectory=build
   dh_testroot -i -O--buildsystem=golang -O--builddirectory=build
   dh_prep -i -O--buildsystem=golang -O--builddirectory=build
	rm -f -- debian/golang-golang-x-net-dev.substvars debian/golang-go.net-dev.substvars
	rm -fr -- debian/.debhelper/generated/golang-golang-x-net-dev/ debian/golang-golang-x-net-dev/ debian/tmp/ debian/.debhelper/generated/golang-go.net-dev/ debian/golang-go.net-dev/
   dh_auto_install -i -O--buildsystem=golang -O--builddirectory=build
	install -d debian/golang-golang-x-net-dev debian/golang-go.net-dev
	cd build && mkdir -p /<<BUILDDIR>>/golang-golang-x-net-dev-0.0\+git20180124.0ed95ab\+dfsg/debian/tmp/usr/share/gocode/src/golang.org/x/net
	cd build && cp -r -T src/golang.org/x/net /<<BUILDDIR>>/golang-golang-x-net-dev-0.0\+git20180124.0ed95ab\+dfsg/debian/tmp/usr/share/gocode/src/golang.org/x/net
   dh_install -i -O--buildsystem=golang -O--builddirectory=build
	install -d debian/golang-golang-x-net-dev//usr/share
	cp --reflink=auto -a debian/tmp/usr/share/gocode debian/golang-golang-x-net-dev//usr/share/
	install -d debian/.debhelper/generated/golang-golang-x-net-dev
	install -d debian/.debhelper/generated/golang-go.net-dev
   dh_installdocs -i -O--buildsystem=golang -O--builddirectory=build
dh_installdocs: Cannot find (any matches for) "README" (tried in .)

	install -d debian/golang-golang-x-net-dev/usr/share/doc/golang-golang-x-net-dev
debian/rules:13: recipe for target 'binary-indep' failed
make: *** [binary-indep] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -A" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-golang-x-net-dev.html

[ Note: There has been a recent change in debhelper behaviour, the current
  behaviour is the intended one. See Bug #903133 for details ].

Thanks.