[pkg-go] Fwd: Code review: golang-github-danverbraganza-varcaser

[Anthony Fok]

Hi Tong,

> Have you got around to take a look at my review request?

No, not in depth.  Sorry, I have been really busy in real life, and I
was hoping other pkg-go team members could help you review the
package.  ;-)

Anyhow, I took a quick look at
https://salsa.debian.org/go-team/packages/golang-github-danverbraganza-varcaser
which you committed two weeks ago and noticed these two problems:

 1. The pristine-tar is the default branch (either you or gbp pushed
the branches in the wrong order)

 2. There is no debian/0.0_git20151108.ce61ec4-1 tag

which indicates to me that you are not running the gbp commands in the
right order, or some other issues.

So, I went ahead and removed
https://salsa.debian.org/go-team/packages/golang-github-danverbraganza-varcaser
altogether so you can make a proper build and push to it properly
again.  Instructions below:

On Tue, Jul 17, 2018 at 2:23 AM, Anthony Fok <foka at debian.org> wrote:
> On Thu, Jul 5, 2018 at 2:24 PM, Tong Sun <pkgoyq.xpt at neverbox.com> wrote:
>> Hi,
>>
>> Can anyone delete the  https://salsa.debian.org/go-team/packages/ffcvt  repo
>> for me please?
>
> It has been deleted.  Please try and see if you can push your
> repository now, but note the following CAVEAT:
>
> Your first "gbp push" should be done AFTER you have successfully built
> the package a signed tag
> (e.g. debian/1.0.0-1) with the following command (or equivalent):
>
>     gbp buildpackage --git-pbuilder --git-sign-tags --git-tag
>
> For better or for worse, "gbp push" starts by pushing the debian
> version tag first, and if it doesn't find it, it will proceed to push
> the upstream tag (which the upstream branch contains).
> And Salsa (running GitLab) treats whatever it receives first as the
> default branch.
>
> If you don't want that to happen, and still want to upload your
> work-in-progress package to Salsa, I recommend that you manually push
> your "master" or "debian/sid" branch first by using "git push -u
> origin master" or "git push -u origin debian/sid".
>
> gbp is a great tool, but it is not omnipotent, and it is definitely
> not a replacement for good old "git" in many situations.

Cheers,
Anthony