[pkg-go] Bug#906465: gitaly: FTBFS in buster/sid

[Santiago Vila]

Package: src:gitaly
Version: 0.96.1+debian-2
Severity: serious
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-arch
dh build-arch  --buildsystem=golang --with=golang
   dh_update_autotools_config -a -O--buildsystem=golang
   dh_autoreconf -a -O--buildsystem=golang
   dh_auto_configure -a -O--buildsystem=golang
   debian/rules override_dh_auto_build
make[1]: Entering directory '/<<BUILDDIR>>/gitaly-0.96.1+debian'
dh_auto_build -- \
            -ldflags "-X gitlab.com/gitlab-org/gitaly/internal/version.version=0.96.1+debian"
	cd obj-x86_64-linux-gnu && go install -gcflags=\"-trimpath=/<<BUILDDIR>>/gitaly-0.96.1\+debian/obj-x86_64-linux-gnu/src\" -asmflags=\"-trimpath=/<<BUILDDIR>>/gitaly-0.96.1\+debian/obj-x86_64-linux-gnu/src\" -v -p 1 -ldflags "-X gitlab.com/gitlab-org/gitaly/internal/version.version=0.96.1+debian" gitlab.com/gitlab-org/gitaly/auth gitlab.com/gitlab-org/gitaly/client gitlab.com/gitlab-org/gitaly/cmd/gitaly gitlab.com/gitlab-org/gitaly/cmd/gitaly-ssh gitlab.com/gitlab-org/gitaly/internal/archive gitlab.com/gitlab-org/gitaly/internal/command gitlab.com/gitlab-org/gitaly/internal/config gitlab.com/gitlab-org/gitaly/internal/connectioncounter gitlab.com/gitlab-org/gitaly/internal/diff gitlab.com/gitlab-org/gitaly/internal/git gitlab.com/gitlab-org/gitaly/internal/git/alternates gitlab.com/gitlab-org/gitaly/internal/git/catfile gitlab.com/gitlab-org/gitaly/internal/git/log gitlab.com/gitlab-org/gitaly/internal/helper gitlab.com/gitlab-org/gitaly/internal/helper/fieldextractors gitlab.com/gitlab-org/gitaly/internal/helper/housekeeping gitlab.com/gitlab-org/gitaly/internal/helper/lines gitlab.com/gitlab-org/gitaly/internal/linguist gitlab.com/gitlab-org/gitaly/internal/logsanitizer gitlab.com/gitlab-org/gitaly/internal/middleware/cancelhandler gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/testpb gitlab.com/gitlab-org/gitaly/internal/middleware/metadatahandler gitlab.com/gitlab-org/gitaly/internal/middleware/panichandler gitlab.com/gitlab-org/gitaly/internal/middleware/sentryhandler gitlab.com/gitlab-org/gitaly/internal/rubyserver gitlab.com/gitlab-org/gitaly/internal/rubyserver/balancer gitlab.com/gitlab-org/gitaly/internal/server gitlab.com/gitlab-org/gitaly/internal/server/auth gitlab.com/gitlab-org/gitaly/internal/service gitlab.com/gitlab-org/gitaly/internal/service/blob gitlab.com/gitlab-org/gitaly/internal/service/commit gitlab.com/gitlab-org/gitaly/internal/service/conflicts gitlab.com/gitlab-org/gitaly/internal/service/diff gitlab.com/gitlab-org/gitaly/internal/service/namespace gitlab.com/gitlab-org/gitaly/internal/service/notifications gitlab.com/gitlab-org/gitaly/internal/service/operations gitlab.com/gitlab-org/gitaly/internal/service/ref gitlab.com/gitlab-org/gitaly/internal/service/remote gitlab.com/gitlab-org/gitaly/internal/service/repository gitlab.com/gitlab-org/gitaly/internal/service/server gitlab.com/gitlab-org/gitaly/internal/service/smarthttp gitlab.com/gitlab-org/gitaly/internal/service/ssh gitlab.com/gitlab-org/gitaly/internal/service/wiki gitlab.com/gitlab-org/gitaly/internal/storage gitlab.com/gitlab-org/gitaly/internal/supervisor gitlab.com/gitlab-org/gitaly/internal/supervisor/test-scripts gitlab.com/gitlab-org/gitaly/internal/tempdir gitlab.com/gitlab-org/gitaly/internal/testhelper gitlab.com/gitlab-org/gitaly/internal/version gitlab.com/gitlab-org/gitaly/streamio
golang.org/x/net/context
github.com/golang/protobuf/proto
golang.org/x/net/http2/hpack
golang.org/x/text/transform

[... snipped ...]

golang.org/x/sys/unix
golang.org/x/crypto/ssh/terminal
github.com/sirupsen/logrus
github.com/BurntSushi/toml
gitlab.com/gitlab-org/gitaly/vendor/github.com/certifi/gocertifi
gitlab.com/gitlab-org/gitaly/vendor/github.com/getsentry/raven-go
gitlab.com/gitlab-org/gitaly/vendor/github.com/grpc-ecosystem/go-grpc-prometheus
github.com/kelseyhightower/envconfig
github.com/golang/protobuf/ptypes/struct
github.com/golang/protobuf/jsonpb
gitlab.com/gitlab-org/gitaly/vendor/github.com/grpc-ecosystem/go-grpc-middleware/logging
gitlab.com/gitlab-org/gitaly/vendor/github.com/grpc-ecosystem/go-grpc-middleware/tags
gitlab.com/gitlab-org/gitaly/vendor/github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus
golang.org/x/sync/semaphore
gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler
# gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler
src/gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/metrics.go:109:13: cannot use histogramVec.WithLabelValues(serviceName, methodName) (type prometheus.Observer) as type prometheus.Histogram in assignment:
	prometheus.Observer does not implement prometheus.Histogram (missing Collect method)
gitlab.com/gitlab-org/gitaly/internal/middleware/panichandler
gitlab.com/gitlab-org/gitaly/internal/connectioncounter
gitlab.com/gitlab-org/gitaly/internal/storage
gitlab.com/gitlab-org/gitaly/internal/rubyserver/balancer
gitlab.com/gitlab-org/gitaly/internal/supervisor
gitlab.com/gitlab-org/gitaly/internal/version
gitlab.com/gitlab-org/gitaly/internal/helper/fieldextractors
gitlab.com/gitlab-org/gitaly/internal/logsanitizer
gitlab.com/gitlab-org/gitaly/internal/middleware/cancelhandler
gitlab.com/gitlab-org/gitaly/internal/helper/lines
gitlab.com/gitlab-org/gitaly/internal/archive
gitlab.com/gitlab-org/gitaly/internal/helper/housekeeping
gitlab.com/gitlab-org/gitaly/vendor/google.golang.org/grpc/health/grpc_health_v1
gitlab.com/gitlab-org/gitaly/vendor/google.golang.org/grpc/health
github.com/golang/protobuf/protoc-gen-go/descriptor
gitlab.com/gitlab-org/gitaly/vendor/google.golang.org/grpc/reflection/grpc_reflection_v1alpha
gitlab.com/gitlab-org/gitaly/vendor/google.golang.org/grpc/reflection
gitlab.com/gitlab-org/gitaly/cmd/gitaly-ssh
gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/testpb
gitlab.com/gitlab-org/gitaly/internal/supervisor/test-scripts
github.com/davecgh/go-spew/spew
github.com/pmezard/go-difflib/difflib
github.com/stretchr/testify/assert
github.com/stretchr/testify/require
dh_auto_build: cd obj-x86_64-linux-gnu && go install -gcflags=\"-trimpath=/<<BUILDDIR>>/gitaly-0.96.1\+debian/obj-x86_64-linux-gnu/src\" -asmflags=\"-trimpath=/<<BUILDDIR>>/gitaly-0.96.1\+debian/obj-x86_64-linux-gnu/src\" -v -p 1 -ldflags "-X gitlab.com/gitlab-org/gitaly/internal/version.version=0.96.1+debian" gitlab.com/gitlab-org/gitaly/auth gitlab.com/gitlab-org/gitaly/client gitlab.com/gitlab-org/gitaly/cmd/gitaly gitlab.com/gitlab-org/gitaly/cmd/gitaly-ssh gitlab.com/gitlab-org/gitaly/internal/archive gitlab.com/gitlab-org/gitaly/internal/command gitlab.com/gitlab-org/gitaly/internal/config gitlab.com/gitlab-org/gitaly/internal/connectioncounter gitlab.com/gitlab-org/gitaly/internal/diff gitlab.com/gitlab-org/gitaly/internal/git gitlab.com/gitlab-org/gitaly/internal/git/alternates gitlab.com/gitlab-org/gitaly/internal/git/catfile gitlab.com/gitlab-org/gitaly/internal/git/log gitlab.com/gitlab-org/gitaly/internal/helper gitlab.com/gitlab-org/gitaly/internal/helper/fieldextractors gitlab.com/gitlab-org/gitaly/internal/helper/housekeeping gitlab.com/gitlab-org/gitaly/internal/helper/lines gitlab.com/gitlab-org/gitaly/internal/linguist gitlab.com/gitlab-org/gitaly/internal/logsanitizer gitlab.com/gitlab-org/gitaly/internal/middleware/cancelhandler gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler gitlab.com/gitlab-org/gitaly/internal/middleware/limithandler/testpb gitlab.com/gitlab-org/gitaly/internal/middleware/metadatahandler gitlab.com/gitlab-org/gitaly/internal/middleware/panichandler gitlab.com/gitlab-org/gitaly/internal/middleware/sentryhandler gitlab.com/gitlab-org/gitaly/internal/rubyserver gitlab.com/gitlab-org/gitaly/internal/rubyserver/balancer gitlab.com/gitlab-org/gitaly/internal/server gitlab.com/gitlab-org/gitaly/internal/server/auth gitlab.com/gitlab-org/gitaly/internal/service gitlab.com/gitlab-org/gitaly/internal/service/blob gitlab.com/gitlab-org/gitaly/internal/service/commit gitlab.com/gitlab-org/gitaly/internal/service/conflicts gitlab.com/gitlab-org/gitaly/internal/service/diff gitlab.com/gitlab-org/gitaly/internal/service/namespace gitlab.com/gitlab-org/gitaly/internal/service/notifications gitlab.com/gitlab-org/gitaly/internal/service/operations gitlab.com/gitlab-org/gitaly/internal/service/ref gitlab.com/gitlab-org/gitaly/internal/service/remote gitlab.com/gitlab-org/gitaly/internal/service/repository gitlab.com/gitlab-org/gitaly/internal/service/server gitlab.com/gitlab-org/gitaly/internal/service/smarthttp gitlab.com/gitlab-org/gitaly/internal/service/ssh gitlab.com/gitlab-org/gitaly/internal/service/wiki gitlab.com/gitlab-org/gitaly/internal/storage gitlab.com/gitlab-org/gitaly/internal/supervisor gitlab.com/gitlab-org/gitaly/internal/supervisor/test-scripts gitlab.com/gitlab-org/gitaly/internal/tempdir gitlab.com/gitlab-org/gitaly/internal/testhelper gitlab.com/gitlab-org/gitaly/internal/version gitlab.com/gitlab-org/gitaly/streamio returned exit code 2
make[1]: *** [debian/rules:23: override_dh_auto_build] Error 2
make[1]: Leaving directory '/<<BUILDDIR>>/gitaly-0.96.1+debian'
make: *** [debian/rules:14: build-arch] Error 2
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made with "dpkg-buildpackage -B" in my autobuilder.
Most probably, it also fails here in reproducible builds:

https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/gitaly.html

where you can get a full build log if you need it.

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.