[pkg-go] Bug#908539: golang-github-rjeczalik-notify: FTBFS randomly (TestWatcherInotify fails)

[Santiago Vila]

Package: src:golang-github-rjeczalik-notify
Version: 0.9.1-1
Severity: important
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_autoreconf -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
   dh_auto_build -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go install -gcflags=\"-trimpath=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src\" -asmflags=\"-trimpath=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src\" -v -p 1 github.com/rjeczalik/notify
golang.org/x/sys/unix
github.com/rjeczalik/notify
   dh_auto_test -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go test -vet=off -v -p 1 github.com/rjeczalik/notify
=== RUN   TestEventString
--- PASS: TestEventString (0.00s)
=== RUN   TestNotifySystemAndGlobalMix

[... snipped ...]

=== RUN   TestNonrecursiveTreeInternal
--- PASS: TestNonrecursiveTreeInternal (3.94s)
=== RUN   TestRecursiveTree
--- PASS: TestRecursiveTree (8.36s)
=== RUN   TestRecursiveTreeWatchInactiveMerge
--- PASS: TestRecursiveTreeWatchInactiveMerge (1.84s)
=== RUN   TestRecursiveTree_Windows
--- PASS: TestRecursiveTree_Windows (2.20s)
=== RUN   TestCanonicalNoSymlink
--- PASS: TestCanonicalNoSymlink (0.00s)
=== RUN   TestJoinevents
--- PASS: TestJoinevents (0.00s)
=== RUN   TestTreeSplit
--- PASS: TestTreeSplit (0.00s)
=== RUN   TestTreeBase
--- PASS: TestTreeBase (0.00s)
=== RUN   TestTreeIndexSep
--- PASS: TestTreeIndexSep (0.00s)
=== RUN   TestTreeLastIndexSep
--- PASS: TestTreeLastIndexSep (0.00s)
=== RUN   TestCleanpath
--- SKIP: TestCleanpath (0.00s)
	util_test.go:141: TODO(rjeczalik)
=== RUN   TestCanonical
--- PASS: TestCanonical (0.13s)
=== RUN   TestCanonicalCircular
--- PASS: TestCanonicalCircular (0.13s)
=== RUN   TestCanonical_RelativeSymlink
--- PASS: TestCanonical_RelativeSymlink (0.00s)
=== RUN   TestWatcherInotify
--- FAIL: TestWatcherInotify (3.36s)
	testing_test.go:219: testing_test.go:464: ExpectAny received an event which does not match any of the expected ones (i=0): want one of [&notify.Call{F:"", C:(chan notify.EventInfo)(nil), P:"src/github.com/rjeczalik/fs/fs.go", NP:"", E:0x1, NE:0x0, S:interface {}(nil), Dir:false} &notify.Call{F:"", C:(chan notify.EventInfo)(nil), P:"src/github.com/rjeczalik/fs/fs.go", NP:"", E:0x20, NE:0x0, S:interface {}(nil), Dir:false} &notify.Call{F:"", C:(chan notify.EventInfo)(nil), P:"src/github.com/rjeczalik/fs/fs.go", NP:"", E:0x10, NE:0x0, S:interface {}(nil), Dir:false}]; got notify.InCloseWrite: "/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src/github.com/rjeczalik/notify/testdata/203247513/src/github.com/rjeczalik/fs/fs.go"
=== RUN   TestWatcher
--- PASS: TestWatcher (4.42s)
=== RUN   TestStopPathNotExists
--- PASS: TestStopPathNotExists (3.69s)
=== RUN   TestWatcherUnwatch
--- PASS: TestWatcherUnwatch (4.19s)
=== RUN   TestWatchpoint
--- PASS: TestWatchpoint (0.00s)
FAIL
FAIL	github.com/rjeczalik/notify	51.939s
dh_auto_test: cd obj-x86_64-linux-gnu && go test -vet=off -v -p 1 github.com/rjeczalik/notify returned exit code 1
make: *** [debian/rules:6: build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The failure happens randomly, approximately half of the time for me.

I've put a bunch of build logs here:

https://people.debian.org/~sanvila/build-logs/golang-github-rjeczalik-notify/

Please make the build reliable.

If you need help to reproduce it, please say so. As a last resort I could offer
a test machine where this happens very often.

Thanks.