[pkg-go] Bug#907432: Bug#907432: golang-github-cloudflare-redoctober: FTBFS (too many arguments in call to activation.Listeners)

[Shengjing Zhu]

On Fri, Sep 14, 2018 at 4:45 PM Arnaud Rebillout
<arnaud.rebillout at collabora.com> wrote:
>
> The only reverse dependency for this package is golang-cfssl (also from
> cloudflare).
>
> Upstream never issued a release for redoctober.
>
> Hence we could just assume that redoctober is part of golang-cfssl's
> codebase, keep it embedded in golang-cfssl, and stop packaging it
> separately like we do now.
>
> That would solve the FTBFS, since the part of redoctober that is
> embedded in cfssl doesn't need systemd-go (which is causing the build
> failure mentioned in this bug).
>
> Otherwise we wait for upstream to update its embedded copy of
> systemd-go, but I have no idea how long it will take. Their copy of
> systemd-go is 2 years old. Last commit on redoctober was 6 months ago. I
> don't expect anything to happen anytime soon.
>

For easy bugs, you can always send PR to push upstream,

The bug you mentions with system-go, is caused this upstream commit,
https://github.com/coreos/go-systemd/commit/65cc0ad826177f0ec9f0ee87c1bc5718b0d8ec97#diff-03580c8a576b0bff1bd9c4e7dab211da

And for redoctober, it only has one line using go-systemd, it's

activation.Listeners(true)

>From the go-systemd commit comment, they just removed the arg, and
assume it's default is true.

-- 
Best regards,
Shengjing Zhu