[pkg-go] Bug#907432: golang-github-cloudflare-redoctober: FTBFS (too many arguments in call to activation.Listeners)

[Shengjing Zhu]

On Sat, Sep 15, 2018 at 11:31 AM Arnaud Rebillout
<arnaud.rebillout at collabora.com> wrote:
>
>
> On 09/14/2018 11:02 PM, Shengjing Zhu wrote:
> > On Fri, Sep 14, 2018 at 11:27 PM Arnaud Rebillout
> > <arnaud.rebillout at collabora.com> wrote:
> >> Dear Go team,
> >>
> >> can someone please upload this package? I added the patch to fix the FTBFS.
> >>
> >> https://salsa.debian.org/go-team/packages/golang-github-cloudflare-redoctober
> >>
> >> The only changes to the package are just an update of the debian
> >> packaging files, plus a patch. But I'm sorry to say that I made a mess
> >> with the git history.
> >>
> >> I got carried away and updated the package to the latest snapshot, only
> >> to realize that there was no need
> > Could you give some background why not packaging the latest snapshot.
> > This version is almost 2 years old, and I checked its rdeps,
> >
> > -> golang-github-cloudflare-cfssl -> docker.io,kubernetes,notary
> >
> > Probably we only care docker.io and notary, and I find both are using
> > cloudflare/cfssl 1.3.x(the latest 2 release, pretty new)  in upstream.
> >
>
> Regarding docker: you're right that docker.io is using cfssl 1.3.x in
> master, but the version 18.06 that is currently packaged is using commit
> 7fb22c8 (which is the one packaged right now in Debian).
>
> I didn't tried to see if docker 18.06 can build against cfssl 1.3.x
> though. I just think it's wiser to wait until a latest version of cfssl
> is actually required.
>
> This being said, I already started to work on updating cfssl, and I
> pushed my WIP at
> https://salsa.debian.org/arnaudr-guest/golang-github-cloudflare-cfssl. I
> don't think I will work on that again until there's really a need, ie.
> we update the docker package. In the meantime, if anyone works on this
> package, feel free to cherry-pick if it can save yourself some time.
>
> Just a quick feedback on packaging the latest version of cloudflare-cfssl:
>
> Packaging the latest version requires 2 new dependencies:
> - github.com/cloudflare/backoff
> - github.com/google/certificate-transparency-go
>
> It also requires an update of:
> - golang-github-jmhodges-clock-dev
>
> I already updated jmhodges-clock-dev and pushed the work on salsa,
> however I didn't ask for an upload, as it makes no sense as long as we
> don't update cfssl at the same time. Also, there's another reverse
> depdencies, acmetool. I tried to build acmetool "as is", and it's
> currently FTBFS.
>

sigh, that's awkward for cfssl...

However, I think golang-github-cloudflare-redoctober is safe to
update(without bumping cfssl), at least from the build log,

$ ratt golang-github-cloudflare-redoctober_0.0\~git20180313.c0b30b6\~ds1-1_amd64.changes
2018/09/15 14:56:21 Loading changes file
"golang-github-cloudflare-redoctober_0.0~git20180313.c0b30b6~ds1-1_amd64.changes
2018/09/15 14:56:21  - 2 binary packages:
golang-github-cloudflare-redoctober-dev golang-redoctober
2018/09/15 14:56:21 Corresponding .debs (will be injected when building):
2018/09/15 14:56:21
golang-github-cloudflare-redoctober-dev_0.0~git20180313.c0b30b6~ds1-1_all.deb
2018/09/15 14:56:21
golang-redoctober_0.0~git20180313.c0b30b6~ds1-1_amd64.deb
2018/09/15 14:56:21 Setting -dist=sid (from .changes file)
2018/09/15 14:56:21 Figuring out reverse build dependencies using
dose-ceve(1). This might take a while
2018/09/15 14:57:26 Setting -sbuild_dist=unstable (from .changes file)
2018/09/15 14:57:26 Building package 1 of 4: golang-github-cloudflare-cfssl
2018/09/15 15:02:51 Building package 2 of 4: docker.io
2018/09/15 15:43:31 Building package 3 of 4: kubernetes
2018/09/15 15:43:58 building kubernetes failed: exit status 3
2018/09/15 15:43:58 Building package 4 of 4: notary
2018/09/15 15:47:01 Build results:
2018/09/15 15:47:01 PASSED: notary
2018/09/15 15:47:01 PASSED: golang-github-cloudflare-cfssl
2018/09/15 15:47:01 PASSED: docker.io
2018/09/15 15:47:01 FAILED: kubernetes (see buildlogs/kubernetes_1.7.16+dfsg-1)


I build golang-github-cloudflare-redoctober from your commit b4290e2.


--
Best regards,
Shengjing Zhu