[pkg-go] Bug#910714: consul: Please add missing build-dependencies to consul

[Steve Langasek]

Package: consul
Version: 1.0.7~dfsg1-5
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu cosmic ubuntu-patch

Dear maintainers,

While the consul source package has successfully built in Debian, in Ubuntu
we find that it is failing to build because certain go libraries that are
needed by the source but are not declared as build-dependencies happen to
not be pulled in as indirect build-dependencies.

        cd _build && go install -gcflags=\"-trimpath=/<<BUILDDIR>>/consul-1.0.7\~dfsg1/_build/src\" -asmflags=\"-trimpath=/<<BUILDDIR>>/consul-1.0.7\~dfsg1/_build/src\" -v -p 4 github.com/hashicorp/consul github.com/hashicorp/consul/acl github.com/hashicorp/consul/agent github.com/hashicorp/consul/agent/ae github.com/hashicorp/consul/agent/checks github.com/hashicorp/consul/agent/config github.com/hashicorp/consul/agent/consul github.com/hashicorp/consul/agent/consul/autopilot github.com/hashicorp/consul/agent/consul/fsm github.com/hashicorp/consul/agent/consul/prepared_query github.com/hashicorp/consul/agent/consul/state github.com/hashicorp/consul/agent/exec github.com/hashicorp/consul/agent/local github.com/hashicorp/consul/agent/metadata github.com/hashicorp/consul/agent/mock github.com/hashicorp/consul/agent/pool github.com/hashicorp/consul/agent/router github.com/hashicorp/consul/agent/structs github.com/hashicorp/consul/agent/systemd github.com/hashicorp/consul/agent/token github.com/hashicorp/consul/api github.com/hashicorp/consul/command github.com/hashicorp/consul/command/agent github.com/hashicorp/consul/command/catalog github.com/hashicorp/consul/command/catalog/list/dc github.com/hashicorp/consul/command/catalog/list/nodes github.com/hashicorp/consul/command/catalog/list/services github.com/hashicorp/consul/command/event github.com/hashicorp/consul/command/exec github.com/hashicorp/consul/command/flags github.com/hashicorp/consul/command/forceleave github.com/hashicorp/consul/command/info github.com/hashicorp/consul/command/join github.com/hashicorp/consul/command/keygen github.com/hashicorp/consul/command/keyring github.com/hashicorp/consul/command/kv github.com/hashicorp/consul/command/kv/del github.com/hashicorp/consul/command/kv/exp github.com/hashicorp/consul/command/kv/get github.com/hashicorp/consul/command/kv/imp github.com/hashicorp/consul/command/kv/impexp github.com/hashicorp/consul/command/kv/put github.com/hashicorp/consul/command/leave github.com/hashicorp/consul/command/lock github.com/hashicorp/consul/command/maint github.com/hashicorp/consul/command/members github.com/hashicorp/consul/command/monitor github.com/hashicorp/consul/command/operator github.com/hashicorp/consul/command/operator/autopilot github.com/hashicorp/consul/command/operator/autopilot/get github.com/hashicorp/consul/command/operator/autopilot/set github.com/hashicorp/consul/command/operator/raft github.com/hashicorp/consul/command/operator/raft/listpeers github.com/hashicorp/consul/command/operator/raft/removepeer github.com/hashicorp/consul/command/reload github.com/hashicorp/consul/command/rtt github.com/hashicorp/consul/command/snapshot github.com/hashicorp/consul/command/snapshot/inspect github.com/hashicorp/consul/command/snapshot/restore github.com/hashicorp/consul/command/snapshot/save github.com/hashicorp/consul/command/validate github.com/hashicorp/consul/command/version github.com/hashicorp/consul/command/watch github.com/hashicorp/consul/ipaddr github.com/hashicorp/consul/lib github.com/hashicorp/consul/lib/freeport github.com/hashicorp/consul/logger github.com/hashicorp/consul/sentinel github.com/hashicorp/consul/snapshot github.com/hashicorp/consul/testrpc github.com/hashicorp/consul/testutil github.com/hashicorp/consul/testutil/retry github.com/hashicorp/consul/tlsutil github.com/hashicorp/consul/types github.com/hashicorp/consul/version github.com/hashicorp/consul/watch
src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider/aws/aws_discover.go:9:2: cannot find package "github.com/aws/aws-sdk-go/aws" in any of:
        /<<PKGBUILDDIR>>/_build/src/github.com/hashicorp/consul/vendor/github.com/aws/aws-sdk-go/aws (vendor tree)
        /usr/lib/go-1.10/src/github.com/aws/aws-sdk-go/aws (from $GOROOT)
        /<<PKGBUILDDIR>>/_build/src/github.com/aws/aws-sdk-go/aws (from $GOPATH)
src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/provider

  (https://launchpad.net/ubuntu/+source/consul/1.0.7~dfsg1-5)

There are a number of other missing packages after this first one.

Since these go packages are used by the consul source, it is per se correct
for consul to declare build dependencies on them, even if the package has
successfully built in Debian without the declaration.

Please consider the attached patch, which I have uploaded to Ubuntu to fix
the build failure there.

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru consul-1.0.7~dfsg1/debian/control consul-1.0.7~dfsg1/debian/control
--- consul-1.0.7~dfsg1/debian/control	2018-08-17 01:48:44.000000000 -0700
+++ consul-1.0.7~dfsg1/debian/control	2018-10-09 22:38:08.000000000 -0700
@@ -11,6 +11,7 @@
     ,golang-github-armon-circbuf-dev
     ,golang-github-armon-go-metrics-dev (>= 0.0~git20171117~)
     ,golang-github-armon-go-radix-dev
+    ,golang-github-aws-aws-sdk-go-dev
 #   ,golang-github-beorn7-perks-dev
     ,golang-github-bgentry-speakeasy-dev
     ,golang-github-circonus-labs-circonus-gometrics-dev (>= 1.2.0~)
@@ -18,6 +19,7 @@
     ,golang-github-datadog-datadog-go-dev
     ,golang-github-davecgh-go-spew-dev
     ,golang-github-denverdino-aliyungo-dev
+    ,golang-github-docker-go-connections-dev
     ,golang-github-elazarl-go-bindata-assetfs-dev (>= 0.0~git20151224~)
     ,golang-github-fsouza-go-dockerclient-dev
     ,golang-github-google-gofuzz-dev
@@ -47,6 +49,7 @@
     ,golang-github-hashicorp-serf-dev (>= 0.8.1+git20180508~)
     ,golang-github-hashicorp-yamux-dev (>= 0.0~git20151129~)
     ,golang-github-inconshreveable-muxado-dev
+    ,golang-github-kr-text-dev
     ,golang-github-mattn-go-isatty-dev
     ,golang-github-miekg-dns-dev
     ,golang-github-mitchellh-cli-dev (>= 0.0~git20171129~)
@@ -62,6 +65,7 @@
     ,golang-github-sergi-go-diff-dev
     ,golang-github-shirou-gopsutil-dev
     ,golang-golang-x-sys-dev (>= 0.0~git20161012~)
+    ,golang-google-api-dev
 Homepage: https://github.com/hashicorp/consul
 Vcs-Browser: https://salsa.debian.org/go-team/packages/consul
 Vcs-Git: https://salsa.debian.org/go-team/packages/consul.git