[pkg-go] Bug#914055: gitaly: misses versioned dependency on gitaly-proto (and probably more)

[Paul Gevers]

Package: gitaly
Version: 0.100.1+debian2-1
Severity: serious
X-Debbugs-CC: debian-ci at lists.debian.org, gitlab at packages.debian.org
User: debian-ci at lists.debian.org
Usertags: needs-update
Control: affects -1 src:gitlab

Dear maintainers,

With a recent upload of gitlab the autopkgtest of gitaly fails in
testing when that autopkgtest is run with the binary packages of gitlab
from unstable. It passes when run with only packages from testing. In
tabular form:
                       pass            fail
gitlab                 from testing    11.1.8+dfsg-2
gitaly                 from testing    0.100.1+debian2-1
versioned deps [0]     from testing    from unstable
all others             from testing    from testing

I copied some of the output at the bottom of this report. If I
understand the error message correctly, the failure is due to the fact
that gitaly-proto from testing isn't found. None of our tools is aware
that gitaly-proto version 0.99.0 is a dependency of gitaly 0.100.1
because that dependency isn't declared in the regular way. If I further
read the output of a passing autopkgtest, I fear that there are quite a
few more packages that need documenting.

Currently this regression is contributing to the delay of the migration
of gitlab to testing [1], although that may "fix" itself once
gitaly/0.111.4+debian-2 and golang-gitaly-proto/0.105.0+dfsg-2 migrate
to testing in a couple of days.

If this is a real problem in your package (and not only in your
autopkgtest), the right binary package(s) from gitlab should really add
a versioned Breaks on the unfixed version of (one of your) package(s).
Note: the Breaks is nice even if the issue is only in the autopkgtest as
it helps the migration software to figure out the right versions to
combine in the tests.

More information about this bug and the reason for filing it can be found on
https://wiki.debian.org/ContinuousIntegration/RegressionEmailInformation

Paul
PS: I'd like to let you know that an autopkgtest that only contains a
no-op test (that just installs a package) is NOT wanted by the release
team. It appears to me that your test doesn't do anything that isn't
already done during installation (the logs are the same). Please add
testcases that really use your installed package in any way, or drop
your autopkgtest. We have piuparts testing to check for installability
issues.

[0] You can see what packages were added from the second line of the log
file quoted below. The migration software adds source package from
unstable to the list if they are needed to install packages from
gitlab/11.1.8+dfsg-2. I.e. due to versioned dependencies or
breaks/conflicts.
[1] https://qa.debian.org/excuses.php?package=gitlab

https://ci.debian.net/data/autopkgtest/testing/amd64/g/gitaly/1330154/log.gz

Setting up gitaly (0.100.1+debian2-1) ...
Could not find gem 'gitaly-proto (~> 0.99.0)' in any of the gem
sources listed
in your Gemfile.
dpkg: error processing package gitaly (--configure):
 installed gitaly package post-installation script subprocess returned
error exit status 7
dpkg: dependency problems prevent configuration of autopkgtest-satdep:
 autopkgtest-satdep depends on gitaly; however:
  Package gitaly is not configured yet.

dpkg: error processing package autopkgtest-satdep (--configure):
 dependency problems - leaving unconfigured
Processing triggers for libc-bin (2.27-8) ...
Processing triggers for ca-certificates (20170717) ...
Updating certificates in /etc/ssl/certs...
0 added, 0 removed; done.
Running hooks in /etc/ca-certificates/update.d...
done.
Processing triggers for systemd (239-11) ...
Errors were encountered while processing:
 gitaly

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-go-maintainers/attachments/20181118/306227ea/attachment.sig>