[pkg-go] Bug#923823: golang-gopkg-mcuadros-go-syslog.v2: FTBFS randomly (failing tests)

[Santiago Vila]

Package: src:golang-gopkg-mcuadros-go-syslog.v2
Version: 2.2.1-1
Severity: important
Tags: ftbfs

Dear maintainer:

I tried to build this package in buster but it failed:

--------------------------------------------------------------------------------
[...]
 debian/rules build-indep
dh build-indep --buildsystem=golang --with=golang
   dh_update_autotools_config -i -O--buildsystem=golang
   dh_autoreconf -i -O--buildsystem=golang
   dh_auto_configure -i -O--buildsystem=golang
   dh_auto_build -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go install -gcflags=all=\"-trimpath=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src\" -asmflags=all=\"-trimpath=/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu/src\" -v -p 2 gopkg.in/mcuadros/go-syslog.v2 gopkg.in/mcuadros/go-syslog.v2/format gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc3164 gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc5424
errors
internal/cpu
internal/race
runtime/internal/atomic
runtime/internal/sys
internal/bytealg
sync/atomic
unicode
runtime
unicode/utf8
container/list
math
math/bits
strconv
crypto/internal/subtle
crypto/subtle
internal/testlog
crypto/rc4
vendor/golang_org/x/crypto/cryptobyte/asn1
vendor/golang_org/x/net/dns/dnsmessage
internal/nettrace
runtime/cgo
vendor/golang_org/x/crypto/curve25519
sync
io
reflect
bytes
bufio
hash
crypto
crypto/cipher
crypto/aes
syscall
encoding/binary
time
crypto/des
internal/syscall/unix
math/rand
strings
internal/poll
crypto/internal/randutil
crypto/sha512
crypto/hmac
os
crypto/md5
crypto/sha1
crypto/sha256
fmt
encoding/base64
sort
encoding/pem
path/filepath
math/big
encoding/hex
io/ioutil
context
internal/singleflight
net
crypto/elliptic
encoding/asn1
crypto/ecdsa
crypto/rand
crypto/rsa
crypto/dsa
crypto/x509/pkix
vendor/golang_org/x/crypto/cryptobyte
net/url
vendor/golang_org/x/crypto/internal/chacha20
vendor/golang_org/x/crypto/poly1305
vendor/golang_org/x/crypto/chacha20poly1305
gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser
gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc3164
gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc5424
gopkg.in/mcuadros/go-syslog.v2/format
crypto/x509
crypto/tls
gopkg.in/mcuadros/go-syslog.v2
   dh_auto_test -i -O--buildsystem=golang
	cd obj-x86_64-linux-gnu && go test -vet=off -v -p 2 gopkg.in/mcuadros/go-syslog.v2 gopkg.in/mcuadros/go-syslog.v2/format gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc3164 gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc5424
=== RUN   Test

----------------------------------------------------------------------
FAIL: servertls_test.go:57: ServerSuite.TestTLS

servertls_test.go:80:
    c.Check(handler.LastLogParts["hostname"], Equals, "hostname")
... obtained = nil
... expected string = "hostname"
... runtime error: invalid memory address or nil pointer dereference

servertls_test.go:81:
    c.Check(handler.LastLogParts["tag"], Equals, "tag")
... obtained = nil
... expected string = "tag"
... runtime error: invalid memory address or nil pointer dereference

servertls_test.go:82:
    c.Check(handler.LastLogParts["content"], Equals, "content")
... obtained = nil
... expected string = "content"
... runtime error: invalid memory address or nil pointer dereference

servertls_test.go:83:
    c.Check(handler.LastLogParts["tls_peer"], Equals, "dummycert1")
... obtained = nil
... expected string = "dummycert1"
... runtime error: invalid memory address or nil pointer dereference

servertls_test.go:84:
    c.Check(handler.LastMessageLength, Equals, int64(len(exampleSyslog)))
... obtained int64 = 0
... expected int64 = 46

OOPS: 14 passed, 1 FAILED
--- FAIL: Test (2.39s)
FAIL
FAIL	gopkg.in/mcuadros/go-syslog.v2	2.394s
=== RUN   Test
OK: 6 passed
--- PASS: Test (0.00s)
PASS
ok  	gopkg.in/mcuadros/go-syslog.v2/format	0.005s
=== RUN   Test
OK: 13 passed
--- PASS: Test (0.00s)
PASS
ok  	gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser	0.006s
=== RUN   Test
OK: 15 passed
--- PASS: Test (0.00s)
PASS
ok  	gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc3164	0.009s
=== RUN   Test
OK: 54 passed
--- PASS: Test (0.01s)
PASS
ok  	gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc5424	0.013s
dh_auto_test: cd obj-x86_64-linux-gnu && go test -vet=off -v -p 2 gopkg.in/mcuadros/go-syslog.v2 gopkg.in/mcuadros/go-syslog.v2/format gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc3164 gopkg.in/mcuadros/go-syslog.v2/internal/syslogparser/rfc5424 returned exit code 1
make: *** [debian/rules:6: build-indep] Error 1
dpkg-buildpackage: error: debian/rules build-indep subprocess returned exit status 2
--------------------------------------------------------------------------------

The build was made in one of my autobuilders with "dpkg-buildpackage -A".

The failure happens randomly, i.e. sometimes it fails, sometimes it does not,
so I don't have a "recipe" to reproduce it as such, but the "randomness"
is reproducible in my autobuilders (i.e. when I build it a lot of times,
there are always some failed builds).

I've put several failed build logs here for reference:

https://people.debian.org/~sanvila/build-logs/golang-gopkg-mcuadros-go-syslog.v2/

If you need a test machine to reproduce this, please contact me
privately and I could provide ssh access to a machine where it happens
(caveat: randomly and maybe with low probability).

If this is really a bug in one of the build-depends, please use reassign and affects,
so that this is still visible in the BTS web page for this package.

Thanks.