[pkg-go] Bug#931662: gitlab-workhorse autopkgtest requires netstat but lacks test dep

[Steve Langasek]

Source: gitlab-workhorse
Version: 7.6.0+debian-1
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu eoan ubuntu-patch

Dear maintainers,

The autopkgtests for gitlab-workhorse have recently started failing in
Ubuntu, because they need the 'netstat' command to be available but lack a
test dependency on this tool:

[...]
autopkgtest [21:45:46]: test listeningPort: [-----------------------
+ timeout 15 bash -c until echo > /dev/tcp/localhost/8181; do sleep 0.5; done
+ gitlab-workhorse
bash: connect: Connection refused
bash: /dev/tcp/localhost/8181: Connection refused
time="2019-07-08T21:45:46Z" level=info msg=Starting version="gitlab-workhorse (unknown version)"
+ grep 8181
+ netstat -ntap
/tmp/autopkgtest.eQTsKe/build.WGQ/src/debian/tests/listeningPort: 6: /tmp/autopkgtest.eQTsKe/build.WGQ/src/debian/tests/listeningPort: netstat: not found
autopkgtest [21:45:47]: test listeningPort: -----------------------]
[...]

   (http://autopkgtest.ubuntu.com/packages/g/gitlab-workhorse/eoan/amd64)

It happens that the netstat is present preinstalled in the Debian
autopkgtest environment, which is why tests don't fail on ci.debian.net. 
However, net-tools is not an essential package, and is in fact in the
process of being deprecated in favor of iproute2, so is not guaranteed to be
installed going forward.

To fix this, gitlab-workhorse can simply add net-tools to the list of
depends in debian/tests/control.

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-go-maintainers/attachments/20190708/25ab8dee/attachment.sig>