[pkg-go] Bug#918619: Bug#918619: golang-github-go-errors-errors FTBFS with Go 1.11

[Anthony Fok]

severity 918619 important
tags 918619 + buster
thanks

On Mon, Jan 7, 2019 at 12:39 PM Adrian Bunk <bunk at debian.org> wrote:
>
> Source: golang-github-go-errors-errors
> Version: 1.0.1-1
> Severity: serious
> Tags: ftbfs
>
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/golang-github-go-errors-errors.html
>
> ...
> === RUN   TestStackFormat
> --- FAIL: TestStackFormat (0.00s)
>     error_test.go:33: Stack trace does not contain source line: 'a: b(5)'
>     error_test.go:34: /build/1st/golang-github-go-errors-errors-1.0.1/obj-x86_64-linux-gnu/src/github.com/go-errors/errors/error_test.go:21 (0x4f5f35)
>                 TestStackFormat.func1: e, expected := Errorf("hi"), callers()
>         /usr/lib/go-1.11/src/runtime/asm_amd64.s:522 (0x455b3b)
>                 call32: CALLFN(·call32, 32)
>         /usr/lib/go-1.11/src/runtime/panic.go:513 (0x429df9)
>                 gopanic: reflectcall(nil, unsafe.Pointer(d.fn), deferArgs(d), uint32(d.siz), uint32(d.siz))
>         /build/1st/golang-github-go-errors-errors-1.0.1/obj-x86_64-linux-gnu/src/github.com/go-errors/errors/error_test.go:245 (0x4f38ff)
>                 TestStackFormat: panic('a')
>         /usr/lib/go-1.11/src/testing/testing.go:827 (0x4b573f)
>                 tRunner: fn(t)
>         /usr/lib/go-1.11/src/runtime/asm_amd64.s:1333 (0x4576d1)
>                 goexit: BYTE    $0x90   // NOP

Pleasantly surprisingly, this error no longer occurs with Go 1.12.
As bullseye (testing) and sid (unstable) have already moved to golang-1.12,
this FTBFS bug is now only confined to Debian 10 "buster" (stable),
thus I think it is appropriate to downgrade this bug's severity from
"serious" to "important" so as not to block testing migration to bullseye.

Cheers,
Anthony Fok