[pkg-go] Bug#935167: prometheus-node-exporter: apt.sh text collector fails to deal with spaces in repository label

[Sven Hoexter]

Package: prometheus-node-exporter
Version: 0.17.0+ds-3
Severity: normal

Hi,
the apt.sh script currently shipped with the prometheus-node-exporter package is not
able to deal with spaces in the repository label.
Result is output like:

~$ /usr/share/prometheus-node-exporter/apt.sh |grep Postgre
apt_upgrades_pending{origin="PostgreSQLfor",arch="Debian/Ubuntu"} 6
apt_upgrades_pending{origin="PostgreSQLfor",arch="Debian/Ubuntu"} 9

This fails basically because of duplicate label in a prometheus metric.
Beside of that the label values are of course wrong.

Anyway this is fixed upstream in:
https://github.com/prometheus-community/node-exporter-textfile-collector-scripts/commit/505079407a638c6a3cce6a7ce434500463d9cb28

Sadly the scripts were moved to a different repo lately and thus
probably missed by the packaging.
https://github.com/prometheus/node_exporter/tree/master/text_collector_examples

I'm not yet sure how we could handle that in a good way with the current packaging.
Either using git submodules or having several upstream branches and merge them somehow,
or build from several source packages.

Opened a MR at
https://salsa.debian.org/go-team/packages/prometheus-node-exporter/merge_requests/3
though I'd consider that at most a temporary workaround. The packaging basically
requires some adjustment to handle this unfortunate source split upstream.

Regards,
Sven

-- System Information:
Debian Release: 10.0
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable'), (90, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-5-amd64 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages prometheus-node-exporter depends on:
ii  libc6         2.28-10
ii  moreutils     0.62-1
ii  systemd-sysv  241-5

Versions of packages prometheus-node-exporter recommends:
ii  dbus           1.12.16-1
ii  python3        3.7.3-1
pn  smartmontools  <none>

prometheus-node-exporter suggests no packages.