[pkg-go] Bug#942331: google-cloud-print-connector FTBFS with current cups (was: google-cloud-print-connector: FTBFS during rebuild with libsnmp35)

[peter green]

tags 942331 +patch
thanks

> Your package is part of the libsnmp transition. During a rebuild your package
> FTBFS on all architectures.
Reading the log more thoroughly it seems the actual failure is cups related.

> cgo-gcc-prolog:95:2: warning: ‘cupsGetPPD3’ is deprecated: Use cupsCopyDestInfo and friends instead. [-Wdeprecated-declarations]
> In file included from src/github.com/google/cloud-print-connector/cups/cups.h:15,
>                   from src/github.com/google/cloud-print-connector/cups/core.go:14:
> /usr/include/cups/ppd.h:360:22: note: declared here
>    360 | extern http_status_t cupsGetPPD3(http_t *http, const char *name, time_t *modtime, char *buffer, size_t bufsize) _CUPS_DEPRECATED_1_6_MSG("Use cupsCopyDestInfo and friends instead.");
>        |                      ^~~~~~~~~~~
> # github.com/google/cloud-print-connector/cups
> cups.c: In function ‘getIPPRequestStatusCode’:
> cups.c:42:12: error: dereferencing pointer to incomplete type ‘ipp_t’ {aka ‘struct _ipp_s’}
>     42 |  return ipp->request.status.status_code;
>        |            ^~
> cups.c: In function ‘getAttributeDateValue’:
> cups.c:47:13: error: dereferencing pointer to incomplete type ‘ipp_attribute_t’ {aka ‘struct _ipp_attribute_s’}
>     47 |  return attr->values[i].date;
>        |             ^~
> crypto
Specifically it seems cups no longer allows direct access to some structures ( https://github.com/apple/cups/commit/0fb02fb9cef39fd0b0c838f11af21d99fe5eab9b#diff-a299fb5293cedc8102f5963e50fbe22c ).

I have whipped up a patch and it seems to build, but I have not tested it beyond that as I do not use google cloud printing. In particular I note that it seems the only way to iterate through the attributes changes ipp->next. I don't know why the the API is designed this way or if this will cause any problems. I also notice that ippGetValueTag applies a mask before returning the tag, again I don't know if that will cause any problems. Also I don't know go, so my changes to the go code should probablly be checked by someone who actually knows the langauge.

I have uploaded my fix to raspbian, a debdiff should appear soon at https://debdiffs.raspbian.org/main/g/google-cloud-print-connector/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-go-maintainers/attachments/20191026/0fcd6f40/attachment.html>