[pkg-go] Bug#952173: golang-gopkg-gorethink-gorethink.v3: FTBFS: dh_auto_test: error: cd obj-x86_64-linux-gnu && go test -vet=off -v -p 4 returned exit code 1

[Anthony Fok]

Control: reassign -1 dh-golang
Control: found -1 1.46
Control: affects -1 src:golang-gopkg-gorethink-gorethink.v3

On Sun, Feb 23, 2020 at 6:18 AM Lucas Nussbaum <lucas at debian.org> wrote:
>
> Source: golang-gopkg-gorethink-gorethink.v3
> Version: 3.0.5-1
> Severity: serious
> Justification: FTBFS on amd64
> Tags: bullseye sid ftbfs
> Usertags: ftbfs-20200222 ftbfs-bullseye
>
> Hi,
>
> During a rebuild of all packages in sid, your package failed to build
> on amd64.

Thank you for the report, Lucas.  I was brought here when, after
uploading a new version of golang-golang-x-net,
https://tracker.debian.org/pkg/golang-golang-x-net reports a
regression:

    autopkgtest for golang-gopkg-gorethink-gorethink.v3/3.0.5-1:
        amd64: Regression ♻ , arm64: Regression ♻

and that eventually led me to this bug report.

It turns out that it is not golang-golang-x-net but rather the
recently uploaded dh-golang 1.46 is the culprit.

> Relevant part (hopefully):
> > make[1]: Entering directory '/<<PKGBUILDDIR>>'
> > # Most tests are disabled because they require RethinkDB,
> > # which is not yet packaged in Debian.
> > export DH_GOLANG_EXCLUDES=" \
> >   gopkg.in/gorethink/gorethink.v3$ \
> >   gopkg.in/gorethink/gorethink.v3/internal/reql_tests \
> > " && \
> > dh_auto_test
> >       cd obj-x86_64-linux-gnu && go test -vet=off -v -p 4
> > can't load package: package .: no Go files in /<<PKGBUILDDIR>>/obj-x86_64-linux-gnu
> > dh_auto_test: error: cd obj-x86_64-linux-gnu && go test -vet=off -v -p 4 returned exit code 1

dh-golang calls "go test" with a whole bunch of added paths but they
are absent here.

Here are the difference command calls between dh-golang 1.45 (-) and 1.46 (+):

-       cd obj-x86_64-linux-gnu && go install
-gcflags=all=\"-trimpath=/home/foka/debian/go-team/gopkg/golang-gopkg-gorethink-gorethink.v3/obj-x86_64-linux-gnu/src\"
-asmflags=all=\"-trimpath=/home/foka/debian/go-team/gopkg/golang-gopkg-gorethink-gorethink.v3/obj-x86_64-linux-gnu/src\"
-v -p 4 gopkg.in/gorethink/gorethink.v3
gopkg.in/gorethink/gorethink.v3/encoding
gopkg.in/gorethink/gorethink.v3/ql2
gopkg.in/gorethink/gorethink.v3/types
+       cd obj-x86_64-linux-gnu && go install -trimpath -v -p 4
gopkg.in/gorethink/gorethink.v3
gopkg.in/gorethink/gorethink.v3/encoding
gopkg.in/gorethink/gorethink.v3/ql2
gopkg.in/gorethink/gorethink.v3/types

(the above looks OK)

-       cd obj-x86_64-linux-gnu && go test -vet=off -v -p 4
gopkg.in/gorethink/gorethink.v3/encoding
gopkg.in/gorethink/gorethink.v3/internal/compare
gopkg.in/gorethink/gorethink.v3/ql2
gopkg.in/gorethink/gorethink.v3/types
-=== RUN   TestDecode
---- PASS: TestDecode (0.00s)
...
+       cd obj-x86_64-linux-gnu && go test -vet=off -v -p 4
+can't load package: package .: no Go files in
/home/foka/debian/go-team/gopkg/golang-gopkg-gorethink-gorethink.v3/obj-x86_64-linux-gnu
+dh_auto_test: error: cd obj-x86_64-linux-gnu && go test -vet=off -v
-p 4 returned exit code 1
+make[1]: *** [debian/rules:17: override_dh_auto_test] Error 25

And I wonder why other Go packages are apparently not affected by this.

I will continue to investigate and hopefully come up with a fix soon.

Cheers,
Anthony