[pkg-go] Bug#994413: textql: FTBFS with Go 1.17

[William 'jawn-smith' Wilson]

Package: textql
Version: 2.0.3-3
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu impish ubuntu-patch

Dear Maintainer,

Package textql currently FTBFS with Go 1.17. This is caused by
a failing build-time test due to a minor change in Go's temp
file name creation.

In Ubuntu, the attached patch was applied to achieve the following:

Successfully build this package with Go 1.17.

  * Fix build-time test that fails with Go 1.17 (LP: #1943749)


Thanks for considering the patch.


-- System Information:
Debian Release: bullseye/sid
  APT prefers hirsute-updates
  APT policy: (500, 'hirsute-updates'), (500, 'hirsute-security'), (500, 'hirsute'), (100, 'hirsute-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.11.0-34-generic (SMP w/32 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff -Nru textql-2.0.3/debian/control textql-2.0.3/debian/control
--- textql-2.0.3/debian/control	2020-09-09 18:21:08.000000000 -0500
+++ textql-2.0.3/debian/control	2021-09-15 12:37:52.000000000 -0500
@@ -1,8 +1,7 @@
 Source: textql
 Section: devel
 Priority: optional
-Maintainer: Ubuntu Developers <ubuntu-devel-discuss at lists.ubuntu.com>
-XSBC-Original-Maintainer: Debian Go Packaging Team <pkg-go-maintainers at lists.alioth.debian.org>
+Maintainer: Debian Go Packaging Team <pkg-go-maintainers at lists.alioth.debian.org>
 Uploaders: ChangZhuo Chen (???) <czchen at debian.org>
 Build-Depends: debhelper (>= 10),
                dh-golang,
diff -Nru textql-2.0.3/debian/patches/0001-fix-csv-test-with-go-1.17.patch textql-2.0.3/debian/patches/0001-fix-csv-test-with-go-1.17.patch
--- textql-2.0.3/debian/patches/0001-fix-csv-test-with-go-1.17.patch	1969-12-31 18:00:00.000000000 -0600
+++ textql-2.0.3/debian/patches/0001-fix-csv-test-with-go-1.17.patch	2021-09-15 12:37:52.000000000 -0500
@@ -0,0 +1,22 @@
+Description: Fix test that is failing with Go 1.17
+ Due to a change in Go 1.17, the file name in the test case
+ TestCSVInputHasAName no longer has the "./" in it, causing
+ it to fail. Stripping that substring from it fixes the test.
+Author: William 'jawn-smith' Wilson <william.wilson at canonical.com>
+Bug: https://github.com/dinedal/textql/issues/135
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/textql/+bug/1943749
+Forwarded: https://github.com/dinedal/textql/pull/136
+Last-Update: 2021-09-15
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/inputs/csv_test.go
++++ b/inputs/csv_test.go
+@@ -134,7 +134,7 @@
+ 	}
+ 
+ 	input, _ := NewCSVInput(opts)
+-	expected := fp.Name()
++	expected := strings.ReplaceAll(fp.Name(), "./", "")
+ 
+ 	if !reflect.DeepEqual(input.Name(), expected) {
+ 		t.Errorf("Name() = %v, want %v", input.Name(), expected)
diff -Nru textql-2.0.3/debian/patches/series textql-2.0.3/debian/patches/series
--- textql-2.0.3/debian/patches/series	1969-12-31 18:00:00.000000000 -0600
+++ textql-2.0.3/debian/patches/series	2021-09-15 12:37:28.000000000 -0500
@@ -0,0 +1 @@
+0001-fix-csv-test-with-go-1.17.patch