<div dir="ltr"><div>Sorry for the late reply, and thanks a lot for your packaging work!</div><div><br></div><div>General comments for all packages you listed in your email:</div><div><br></div><div>• Please use the same license for debian/ as for the rest of the package to avoid headaches when adding a patch to the package.</div><div>• Feel free to bump urgency=low to urgency=medium for a quicker migration to testing.</div><div><br></div><div>Comments which are specific to a package follow inline:</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, May 14, 2015 at 6:33 AM, Potter, Tim (Cloud Services) <span dir="ltr"><<a href="mailto:timothy.potter@hp.com" target="_blank">timothy.potter@hp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi everyone. I’ve made some progress packaging up the dependencies for fleet. Or rather one of the dependencies for golang-libcontainer which is a dependency for fleet. Can someone please take a look with a view to uploading these to unstable?<br>
<br>
I’ve got seven packages that make up the Go web framework, revel, at <a href="http://revel.github.io" target="_blank">http://revel.github.io</a>. Here’s the list of packages, all of which are available for inspection under <a href="http://anonscm.debian.org/cgit/pkg-go" target="_blank">http://anonscm.debian.org/cgit/pkg-go</a><br>
<br>
* golang-revel (ITP: #785168)<br></blockquote><div><br></div><div>With regards to <a href="http://anonscm.debian.org/cgit/pkg-go/packages/golang-revel.git/tree/debian/patches/0001-reparent-x-net-websocket-modules.patch">http://anonscm.debian.org/cgit/pkg-go/packages/golang-revel.git/tree/debian/patches/0001-reparent-x-net-websocket-modules.patch</a>, I think a new upload for x-net is being prepared by tincho@.</div><div><br></div><div>With regards to <a href="http://anonscm.debian.org/cgit/pkg-go/packages/golang-revel.git/tree/debian/rules">http://anonscm.debian.org/cgit/pkg-go/packages/golang-revel.git/tree/debian/rules</a>, can you be more verbose about what the error is? Perhaps we can figure it out.</div><div><br></div><div>The packaging itself LGTM, but I haven’t tested the build as I don’t want to fiddle with my pbuilder setup right now and the dependencies aren’t available in unstable yet.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-gocolorize (ITP: #785169)<br></blockquote><div><br></div><div>LGTM.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-robfig-config (ITP: #785176)<br></blockquote><div><br></div><div>Instead of adding a patch which effectively goes outside the build directory (!), please set <span style="color:rgb(0,0,0);font-size:13.3333330154419px;background-color:initial">DH_GOLANG_INSTALL_ALL so that dh-golang will also install the .cfg files.</span></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-pathtree (ITP: #785179)<br></blockquote><div><br></div><div>debian/docs is empty. Why keep it around?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-gomemcache (ITP: #785174)<br></blockquote><div><br></div><div>LGTM.</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-robfig-go-cache (ITP: #785175)<br></blockquote><div><br></div><div>The override_dh_auto_install target seems useless, as it just calls dh_auto_install…?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-redigo (ITP: #785172)<br></blockquote><div><br></div><div>LGTM.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
There’s a question about some of the package names though. I’ve named the <a href="http://github.com/robfig/config" target="_blank">github.com/robfig/config</a> package golang-robfig-config since golang-config sounded too generic. For golang-robfig-go-cache, since it is a fork of the canonical go-cache at <a href="http://github.com/pmylund/go-cache" target="_blank">github.com/pmylund/go-cache</a>. Rob F’s version has unmarked commits from pmylund, but also some new commits that are used by Revel.<br>
<br>
I’ve tried to assume the Go module naming convention of <a href="http://github.com/username/reponame" target="_blank">github.com/username/reponame</a> but with a golang prefix. I’d appreciate some comments on this idea.<br>
<br>
<br>
Thanks,<br>
<br>
Tim.<br>_______________________________________________<br>
Pkg-go-maintainers mailing list<br>
<a href="mailto:Pkg-go-maintainers@lists.alioth.debian.org">Pkg-go-maintainers@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>