<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 1, 2015 at 8:03 AM, Potter, Tim (Cloud Services) <span dir="ltr"><<a href="mailto:timothy.potter@hp.com" target="_blank">timothy.potter@hp.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">On 5 May 2015, at 5:37 pm, Potter, Tim (Cloud Services) <<a href="mailto:timothy.potter@hp.com">timothy.potter@hp.com</a>> wrote:<br>
><br>
> On 5 May 2015, at 3:28 pm, Tianon Gravi <<a href="mailto:admwiggin@gmail.com">admwiggin@gmail.com</a>> wrote:<br>
>><br>
>> On 4 May 2015 at 23:11, Potter, Tim (Cloud Services)<br>
>> <<a href="mailto:timothy.potter@hp.com">timothy.potter@hp.com</a>> wrote:<br>
>>> I’m a bit of a newcomer to Go but have done some Debian packaging before. I think I’ve nailed all the big things but am more than happy to fix any broken-ness or policy issues that people can find.<br>
>><br>
>> The big one I see is "4.13 Convenience copies of code" [1]. The Go<br>
>> packages in Godeps.json [2] will need to be individually packaged (if<br>
>> they aren't already) and added to Build-Depends (see other golang-*<br>
>> packages in pkg-go for examples), and the Godeps directly probably<br>
>> removed to be sure that it isn't used accidentally in place of the<br>
>> packaged variants.<br>
><br>
> Hi Tianon. Thanks for the reply. Yes - oops that’s kind of a glaring problem with the package so far. I’ll file some more ITP’s and post RFS’s to the list.<br>
<br>
</div></div>Hello again everyone. After a chat on IRC with tianon, I’ve whittled down the required dependencies for fleet by a lot. Most of the ITP’s I created were for libcontainer, which turns out to be already present in golang-docker-dev. This means a lot of wasted work but hey I know a lot more about Go than before!<br>
<br>
The final list of packages for fleet is:<br>
<br>
* fleet<br></blockquote><div><br></div><div>This requires the rest, so I’ll hold off reviewing it.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-clockwork<br></blockquote><div><br></div><div>Uploaded.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-globalconf<br></blockquote><div><br></div><div>Please kill debian/patches/0002-fix-path-for-tests.patch and export DH_GOLANG_INSTALL_ALL := 1 in debian/rules instead.<br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-go-semver<br>
</blockquote><div><br></div><div>Uploaded.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">* golang-go-uuid<br></blockquote><div><br></div><div>The project has moved to <a href="https://github.com/pborman/uuid">https://github.com/pborman/uuid</a>, can you reflect that in the Homepage: field and DH_GOPKG please?</div><div><br></div><div>Additionally, the build fails for me because of a failing test:</div><div><br></div><div><div>--- FAIL: TestNodeID (0.00s)</div><div><span class="" style="white-space:pre"> </span>uuid_test.go:315: NodeInterface "" after SetInteface</div></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-goini<br></blockquote><div><br></div><div>Please kill debian/patches/0001-fix-path-for-tests.patch and export DH_GOLANG_INSTALL_ALL := 1 in debian/rules instead.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* golang-go-systemd (>= 2~git20150505)<br></blockquote><div><br></div><div>As written in the other thread, please push your changes and I can review/sponsor.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
That’s a much more manageable list really.<br>
<br>
Changes made since I posted this original email:<br>
<br>
* verified license for debian/* identical to package license<br>
* removed convencience copies of code for fleet<br>
* set urgency=medium in d/changelog<br>
<br>
Note that an update to golang-go-systemd to add some new files is required, which I’ve just send another email about.<br>
<br>
Thanks!<br>
<span class=""><font color="#888888"><br>
<br>
Tim.<br>
<br>
</font></span><br>_______________________________________________<br>
Pkg-go-maintainers mailing list<br>
<a href="mailto:Pkg-go-maintainers@lists.alioth.debian.org">Pkg-go-maintainers@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers</a><br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>