<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On 8 October 2016 at 09:46, Peter Colberg <span dir="ltr"><<a href="mailto:peter@colberg.org" target="_blank">peter@colberg.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Martín,<br>
<br>
Thanks for the quick review.<br>
<span class=""><br>
On Fri, Oct 07, 2016 at 12:51:14PM +0200, Martín Ferrari wrote:<br>
> It is indeed peculiar, and I wonder what ftp-master will think of it.<br>
> Tracking license info for each commit could be fine, but the license<br>
> needs to be in the repository, otherwise an exported tarball has no<br>
> license. He could also import the license in each file if he wanted to<br>
> make sure everyone is aware...<br>
<br>
</span>I am hoping that ftp-master considers a Debian source package an<br>
inseparable unit. I will repack the orig tarballs otherwise. In the<br>
latest version of acmetool, the upstream author has gone as far as<br>
removing the existing license file in favour of the RILTS scheme.<br>
<br>
<a href="https://github.com/hlandau/acme/commit/a4d55ea51a8782633d7ca477d24c5da9a5c6147b" rel="noreferrer" target="_blank">https://github.com/hlandau/<wbr>acme/commit/<wbr>a4d55ea51a8782633d7ca477d24c5d<wbr>a9a5c6147b</a><br>
<span class=""><br>
> Comments on the package (I only checked goutils):<br>
<br>
</span>I applied the changes below to all three packages.<br>
<span class=""><br>
> * Replace the golang-go build-dependency with golang-any, which brings<br>
> gccgo where golang-go is not available.<br>
<br>
</span>Done. To test compilation with gccgo, I temporarily replaced the build<br>
dependency on golang-any with gccgo-6, but the build fails on amd64:<br>
<br>
dh build --buildsystem=golang --with=golang<br>
dh_testdir -O--buildsystem=golang<br>
dh_update_autotools_config -O--buildsystem=golang<br>
dh_auto_configure -O--buildsystem=golang<br>
dh_auto_build -O--buildsystem=golang<br>
go install -v -p 1<br>
dh_auto_build: go install -v -p 1 failed to to execute: No such file or directory<br>
debian/rules:4: recipe for target 'build' failed<br>
make: *** [build] Error 2<br>
dpkg-buildpackage: error: debian/rules build gave error exit status 2<br>
<br>
Is this a bug in dh-golang or gccgo-6?</blockquote><div><br></div><div>I don't know, but it's not surprising to me. The issue that is that gccgo-6 does not install /usr/bin/go, rather it installs /usr/bin/go-6 (so you can have gccgo-6 and golang-go both installed on systems where both are available). When you install golang-any on a system where it brings in gccgo-6 it installs a symlink from /usr/bin/go to go-6. This is a bit of a pain for the reasons you've noticed, but I'm not sure what to do about it.</div><div><br></div><div>Cheers,</div><div>mwh</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> * Drop the golang-go dependency in the binary package, as it is not<br>
> really needed.<br>
<br>
</span>Done.<br>
<span class=""><br>
> * The description is too vague, this package is actually only useful for<br>
> his other utilities, so I'd specify that more clearly.<br>
<br>
</span>Done. I extended the description to mention acmetool.<br>
<span class=""><br>
> * In debian/copyright you say it is Expat license, but then your patch<br>
> says it is MIT.<br>
<br>
</span>Please take another look at upstream-license.patch: The description<br>
does not mention MIT at all; it is only used in the upstream filename.<br>
<br>
What is known as MIT license in the outside world, is considered<br>
ambiguous by Debian and more precisely referred to as the Expat<br>
license. Please see the license specification for debian/copyright:<br>
<br>
<a href="https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification" rel="noreferrer" target="_blank">https://www.debian.org/doc/<wbr>packaging-manuals/copyright-<wbr>format/1.0/#license-<wbr>specification</a><br>
<br>
“There are many versions of the MIT license. Please use Expat instead, when it matches.”<br>
<span class=""><br>
> * The copyright info for clock/* does not reflect anything in the<br>
> repository.<br>
<br>
</span>The author conveniently moved this to the bottom of clock/clock.go:<br>
<br>
// © 2015 Jonathan Boulle Apache 2.0 License<br>
<br>
The debian/copyright stanza stems from golang-github-hlandau-<wbr>degoutils, which<br>
as mentioned in the ITP bug is the predecessor of goutils and will be removed<br>
once the three new dependencies have been accepted. Since degoutils has been<br>
accepted by ftp-masters before, the debian/copyright stanza should be fine.<br>
<span class=""><br>
> Seeing his replies, I am not sure it will be a pleasant upstream to work<br>
> with :(<br>
<br>
</span>I was pondering seeking another maintainer or otherwise orphaning the<br>
package when the behaviour of the maintainer was blocking an important<br>
fix. I temporarily solved the issue by adding a patch that reverted to<br>
the older degoutils as a build dependency, but I thought long and hard<br>
whether it is worth it to continue maintaining acmetool.<br>
<br>
<a href="https://bugs.debian.org/833494" rel="noreferrer" target="_blank">https://bugs.debian.org/833494</a><br>
<br>
Currently I believe it continues to be worth it. Apart from this one<br>
bug, acmetool has generally required the least amount of attention of<br>
the LE clients in Debian, since it is well designed and just works.<br>
acmetool uses a well thought-out and documented directory schema:<br>
<br>
<a href="https://github.com/hlandau/acme/blob/master/_doc/SCHEMA.md" rel="noreferrer" target="_blank">https://github.com/hlandau/<wbr>acme/blob/master/_doc/SCHEMA.<wbr>md</a><br>
<span class="HOEnZb"><font color="#888888"><br>
Peter<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
______________________________<wbr>_________________<br>
Pkg-go-maintainers mailing list<br>
<a href="mailto:Pkg-go-maintainers@lists.alioth.debian.org">Pkg-go-maintainers@lists.<wbr>alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers" rel="noreferrer" target="_blank">http://lists.alioth.debian.<wbr>org/cgi-bin/mailman/listinfo/<wbr>pkg-go-maintainers</a></div></div></blockquote></div><br></div></div>