<div dir="ltr">I uploaded fixes for:<div><br></div><div>• golang-github-julienschmidt-httprouter</div><div>• golang-gopkg-macaroon-bakery.v2</div><div>• golang-github-asaskevich-govalidator</div><div><br></div><div>…and a new upstream version for golang-golang-x-oauth2, which fixes the test failure.</div><div><br></div><div>…and filed upstream issues for:</div><div><br></div><div>• <a href="https://github.com/masterzen/winrm/issues/77">https://github.com/masterzen/winrm/issues/77</a><br></div><div>• <a href="https://github.com/tylerb/graceful/issues/106">https://github.com/tylerb/graceful/issues/106</a><br></div><div><br></div><div>(Help welcome! I couldn’t easily figure out the issues.)</div><div><br></div><div>gopherjs seems to be tied to the compiler version fairly strictly, so I think we’ll have to update it after Go 1.10 is available.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 15, 2018 at 9:26 PM, Michael Stapelberg <span dir="ltr"><<a href="mailto:stapelberg@debian.org" target="_blank">stapelberg@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Here’s one more, which my tooling couldn’t find before due to an unrelated bug:<div><br></div><div>golang-github-asaskevich-<wbr>govalidator<br></div><div><br></div><div><div>--- FAIL: TestIsRequestURI (0.00s)</div><div> validator_test.go:736: Expected IsRequestURI("irc://#channel@<wbr>network") to be true, got false</div><div>--- FAIL: TestIsRequestURL (0.00s)</div><div> validator_test.go:687: Expected IsRequestURL("irc://#channel@<wbr>network") to be true, got false</div><div>FAIL</div><div>FAIL <a href="http://github.com/asaskevich/govalidator" target="_blank">github.com/asaskevich/<wbr>govalidator</a> 0.025s</div></div><div><br></div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Thu, Feb 15, 2018 at 1:14 PM, Michael Stapelberg <span dir="ltr"><<a href="mailto:stapelberg@debian.org" target="_blank">stapelberg@debian.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hey,<div><br></div><div>I did a quick rebuild of our packages with Go 1.10 (I plan to write in more detail about the infrastructure I used in the next few days) and noticed the following new failures:</div><div><br></div><div><div>no longer compiles: <a href="http://github.com/gopherjs/gopherjs" target="_blank">github.com/gopherjs/gopherjs</a>. error exit status 2</div><div>no longer passes tests: <a href="http://github.com/julienschmidt/httprouter" target="_blank">github.com/julienschmidt/httpr<wbr>outer</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://github.com/masterzen/winrm" target="_blank">github.com/masterzen/winrm</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://golang.org/x/oauth2" target="_blank">golang.org/x/oauth2</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://gopkg.in/macaroon-bakery.v2" target="_blank">gopkg.in/macaroon-bakery.v2</a>. error exit status 1</div><div>no longer <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">passes<span> </span></span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">tests</span>: <a href="http://gopkg.in/tylerb/graceful.v1" target="_blank">gopkg.in/tylerb/graceful.v1</a>. error exit status 1</div></div><div><br></div><div>Caveat: there may be others which were broken before for unrelated reasons, but this list seems like a good start.</div><div><br></div><div>If anyone would like to help with proactively fixing these issues, that’d be appreciated! I expect that most often, importing a new upstream version entirely, or cherry-picking an upstream commit would be all that’s necessary.</div><div><br></div><div>Thanks in advance!</div><div><br></div><div>Here are the full error logs:</div><div><br></div><div><div><a href="http://github.com/gopherjs/gopherjs" target="_blank">github.com/gopherjs/gopherjs</a>. error exit status 2</div><div># <a href="http://github.com/gopherjs/gopherjs/compiler" target="_blank">github.com/gopherjs/gopherjs/c<wbr>ompiler</a></div><div>/srv/gopath/src/<a href="http://github.com/gopherjs/gopherjs/compiler/compiler.go:20:9" target="_blank">github.com/gop<wbr>herjs/gopherjs/compiler/compil<wbr>er.go:20:9</a>: undefined: ___GOPHERJS_REQUIRES_GO_VERSIO<wbr>N_1_9___</div><div><br></div><div><div>no longer compiles: <a href="http://github.com/julienschmidt/httprouter" target="_blank">github.com/julienschmidt/httpr<wbr>outer</a>. error exit status 1</div><div>--- FAIL: TestRouterNotFound (0.00s)</div><div> router_test.go:234: NotFound handling route /path/ failed: Code=301, Header=map[Location:[/path] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /dir failed: Code=301, Header=map[Location:[/dir/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route failed: Code=301, Header=map[Location:[/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /PATH failed: Code=301, Header=map[Location:[/path] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /DIR/ failed: Code=301, Header=map[Location:[/dir/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /PATH/ failed: Code=301, Header=map[Content-Type:[text/<wbr>html; charset=utf-8] Location:[/path]]</div><div> router_test.go:234: NotFound handling route /DIR failed: Code=301, Header=map[Location:[/dir/] Content-Type:[text/html; charset=utf-8]]</div><div> router_test.go:234: NotFound handling route /../path failed: Code=301, Header=map[Location:[/path] Content-Type:[text/html; charset=utf-8]]</div><div>FAIL</div><div>FAIL <a href="http://github.com/julienschmidt/httprouter" target="_blank">github.com/julienschmidt/httpr<wbr>outer</a> 0.016s</div></div><div><br></div><div><div><a href="http://github.com/masterzen/winrm" target="_blank">github.com/masterzen/winrm</a>. error exit status 1</div><div><br></div><div>------------------------------<wbr>------------------------------<wbr>----------</div><div>FAIL: client_test.go:89: WinRMSuite.TestRunWithString</div><div><br></div><div>client_test.go:100:</div><div> c.Assert(stdout, Equals, "That's all folks!!!")</div><div>... obtained string = "That's all folks!!!\x00\x00\x00\x00\x00\x<wbr>00\x00\x00\x00\x00\x00\x00\x00<wbr>\x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00\x00\x00\x00\x00\x00\<wbr>x00\x00"</div><div>... expected string = "That's all folks!!!"</div><div><br></div><div>OOPS: 36 passed, 1 FAILED</div><div>--- FAIL: Test (5.03s)</div><div>FAIL</div><div>FAIL <a href="http://github.com/masterzen/winrm" target="_blank">github.com/masterzen/winrm</a> 5.041s</div></div><div><br></div><div><div><a href="http://golang.org/x/oauth2" target="_blank">golang.org/x/oauth2</a>. error exit status 1</div><div>ok <a href="http://golang.org/x/oauth2" target="_blank">golang.org/x/oauth2</a> (cached)</div><div>? <a href="http://golang.org/x/oauth2/amazon" target="_blank">golang.org/x/oauth2/amazon</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/bitbucket" target="_blank">golang.org/x/oauth2/bitbucket</a><wbr> [no test files]</div><div>ok <a href="http://golang.org/x/oauth2/clientcredentials" target="_blank">golang.org/x/oauth2/clientcred<wbr>entials</a> (cached)</div><div>? <a href="http://golang.org/x/oauth2/facebook" target="_blank">golang.org/x/oauth2/facebook</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/fitbit" target="_blank">golang.org/x/oauth2/fitbit</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/foursquare" target="_blank">golang.org/x/oauth2/foursquar<wbr>e</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/github" target="_blank">golang.org/x/oauth2/github</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/heroku" target="_blank">golang.org/x/oauth2/heroku</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/hipchat" target="_blank">golang.org/x/oauth2/hipchat</a> [no test files]</div><div>--- FAIL: TestRetrieveTokenBustedNoSecre<wbr>t (0.00s)</div><div> token_test.go:42: RetrieveToken = unexpected end of JSON input; want no error</div><div>--- FAIL: TestRetrieveTokenWithContexts (0.00s)</div><div> token_test.go:91: RetrieveToken (with background context) = unexpected end of JSON input; want no error</div><div>FAIL</div><div>FAIL <a href="http://golang.org/x/oauth2/internal" target="_blank">golang.org/x/oauth2/internal</a> 0.004s</div><div>ok <a href="http://golang.org/x/oauth2/jws" target="_blank">golang.org/x/oauth2/jws</a> (cached)</div><div>ok <a href="http://golang.org/x/oauth2/jwt" target="_blank">golang.org/x/oauth2/jwt</a> (cached)</div><div>? <a href="http://golang.org/x/oauth2/linkedin" target="_blank">golang.org/x/oauth2/linkedin</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/mediamath" target="_blank">golang.org/x/oauth2/mediamath</a><wbr> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/microsoft" target="_blank">golang.org/x/oauth2/microsoft</a><wbr> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/odnoklassniki" target="_blank">golang.org/x/oauth2/odnoklass<wbr>niki</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/paypal" target="_blank">golang.org/x/oauth2/paypal</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/slack" target="_blank">golang.org/x/oauth2/slack</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/uber" target="_blank">golang.org/x/oauth2/uber</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/vk" target="_blank">golang.org/x/oauth2/vk</a> [no test files]</div><div>? <a href="http://golang.org/x/oauth2/yandex" target="_blank">golang.org/x/oauth2/yandex</a> [no test files]</div></div><div><br></div><div><div><a href="http://gopkg.in/macaroon-bakery.v2" target="_blank">gopkg.in/macaroon-bakery.v2</a>. error exit status 1</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery" target="_blank">gopkg.in/macaroon-bakery.v2/ba<wbr>kery</a> (cached)</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery/checkers" target="_blank">gopkg.in/macaroon-bakery.v2/ba<wbr>kery/checkers</a> (cached)</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery/identchecker" target="_blank">gopkg.in/macaroon-bakery.v2/ba<wbr>kery/identchecker</a> (cached)</div><div>? <a href="http://gopkg.in/macaroon-bakery.v2/bakery/internal/macaroonpb" target="_blank">gopkg.in/macaroon-bakery.v2/b<wbr>akery/internal/macaroonpb</a> [no test files]</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakery/mgorootkeystore" target="_blank">gopkg.in/macaroon-bakery.v2/ba<wbr>kery/mgorootkeystore</a> (cached)</div><div>ok <a href="http://gopkg.in/macaroon-bakery.v2/bakerytest" target="_blank">gopkg.in/macaroon-bakery.v2/ba<wbr>kerytest</a> (cached)</div><div><br></div><div>------------------------------<wbr>------------------------------<wbr>----------</div><div>FAIL: keyring_test.go:157: KeyringSuite.TestThirdPartyInf<wbr>oForLocationReturnsStatusInter<wbr>nalServerError</div><div><br></div><div>keyring_test.go:164:</div><div> c.Assert(err, gc.ErrorMatches,</div><div> fmt.Sprintf(`Get %s/discharge/info: cannot unmarshal error response \(status 500 Internal Server Error\): unexpected content type text/plain; want application/json; content: `, ts.URL))</div><div>... error string = "Get <a href="http://127.0.0.1:39547/discharge/info" target="_blank">http://127.0.0.1:39547/dischar<wbr>ge/info</a>: cannot unmarshal error response (status 500 Internal Server Error): unexpected content type \"\"; want application/json; content: \"\""</div><div>... regex string = "Get <a href="http://127.0.0.1:39547/discharge/info" target="_blank">http://127.0.0.1:39547/dischar<wbr>ge/info</a>: cannot unmarshal error response \\(status 500 Internal Server Error\\): unexpected content type text/plain; want application/json; content: "</div><div><br></div><div>OOPS: 45 passed, 1 FAILED</div><div>--- FAIL: TestPackage (1.95s)</div><div>FAIL</div><div>FAIL <a href="http://gopkg.in/macaroon-bakery.v2/httpbakery" target="_blank">gopkg.in/macaroon-bakery.v2/ht<wbr>tpbakery</a> 1.956s</div></div><div><br></div><div><div><a href="http://gopkg.in/tylerb/graceful.v1" target="_blank">gopkg.in/tylerb/graceful.v1</a>. error exit status 1</div><div>2018/02/15 11:02:24 http: TLS handshake error from [::1]:53422: remote error: tls: bad certificate</div><div>--- FAIL: TestHTTP2ListenAndServeTLS (0.10s)</div><div> http2_test.go:48: Error encountered while connecting to test server: Get <a href="https://localhost:9654" target="_blank">https://localhost:9654</a>: tls: failed to parse certificate from server: x509: cannot parse dnsName "Test Intermediate CA"</div><div>2018/02/15 11:02:24 http: TLS handshake error from [::1]:53424: remote error: tls: bad certificate</div><div>--- FAIL: TestHTTP2ListenAndServeTLSConf<wbr>ig (0.10s)</div><div> http2_test.go:48: Error encountered while connecting to test server: Get <a href="https://localhost:9654" target="_blank">https://localhost:9654</a>: tls: failed to parse certificate from server: x509: cannot parse dnsName "Test Intermediate CA"</div><div>FAIL</div><div>FAIL <a href="http://gopkg.in/tylerb/graceful.v1" target="_blank">gopkg.in/tylerb/graceful.v1</a> 4.668s</div></div><span class="m_-2430982118359045948HOEnZb"><font color="#888888"><div><br></div><div><br></div>-- <br><div class="m_-2430982118359045948m_3685907627009927883gmail_signature">Best regards,<br>Michael</div>
</font></span></div></div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-2430982118359045948gmail_signature" data-smartmail="gmail_signature">Best regards,<br>Michael</div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Best regards,<br>Michael</div>
</div>