<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 20, 2018 at 8:09 AM, Arnaud <span dir="ltr"><<a href="mailto:arnaud.rebillout@collabora.com" target="_blank">arnaud.rebillout@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"><span class="gmail-">
<br>
<br>
<div class="gmail-m_2209817607176049103moz-cite-prefix">On 02/20/2018 12:08 AM, Michael
Stapelberg wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">
<div>Are you certain that this commit is actually a
requirement, or just happens to be the latest version the
containerd people tried?</div>
</div>
</div>
</blockquote>
<br></span>
It's just the version that is vendored by containerd. I assumed they
used it for a good reason, that's all. Definitely not certain that
it's needed.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div>Did you test the version currently in Debian and run
into issues?</div>
</div>
</div>
</div>
</blockquote>
<br></span>
No I didn't try, right now I'm just trying to package and bump
everything required by containerd, then package containerd, then
test the whole thing.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div><br>
</div>
<div>I’m not saying importing new upstream versions isn’t a
good idea, I’m just trying to make sure you don’t do any
extra work you don’t want to do.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
I get your point. I thought the best approach was to bump every
dependency first, then package the missing dependencies. But maybe
it's better to package what's missing first, then try containerd,
and then bump dependencies to newer versions if it's really a need.
Especially if I bump to a snapshot version like in the current case,
it's always better to avoid that and stick to official releases,
when they exist.<span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> <br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
- the current debian package for urfave-cli is on <a href="http://anonscm.debian.org" rel="noreferrer" target="_blank">anonscm.debian.org</a>.
So<br>
here I had to create a repository on <a href="http://salsa.debian.org" rel="noreferrer" target="_blank">salsa.debian.org</a>.
Maybe you don't<br>
like that and already have a procedure for migrating
packages from<br>
anonscm to salsa.<br>
</blockquote>
<div><br>
</div>
<div>While it is fine to create new repositories on salsa,
we should either add this repository to the rewritemap
ASAP (+cc aviau) or don’t move it for the time being.</div>
</div>
</div>
</div>
</blockquote>
<br></span>
What is the rewritemap ? </div></blockquote><div><br></div><div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">See <a href="https://salsa.debian.org/salsa/AliothRewriter/tree/master">https://salsa.debian.org/salsa/AliothRewriter/tree/master</a> for details.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">Is Alexandre Viau the person in charge of
migrating go packages to salsa in general ?<br></div></blockquote><div><br></div><div>Yes.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<br>
For the repository we're talking about right now, I understand
there's no need to bump the version right now, as long as I'm not
sure it's needed.<br>
<br>
Should I just delete it, or at least take it out of the go packages
group, and keep it as a personal repo ?</div></blockquote><div><br></div><div>Yes please (whichever of the two you prefer).</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><span class="gmail-"><br>
<br>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> Overall, your changes look good to me. Let me know
which way you prefer to proceed regarding repository
location, fix the changelog, and I can upload it for you.<br>
</div>
</div>
</div>
</div>
</blockquote>
<br></span>
Let's just wait until we're sure this version bump is really needed,
if you're ok with that.<br></div></blockquote><div><br></div><div>Sure!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<br>
Thanks again for all the thorough feedback !<span class="gmail-HOEnZb"><font color="#888888"><br>
<br>
Arnaud<br>
<br>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>