<div dir="ltr">I can’t have a look at the individual packages right now (but might have some time in the evening/over the weekend), but here’s some quick feedback:<br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Feb 23, 2018 at 11:01 AM, Arnaud <span dir="ltr"><<a href="mailto:arnaud.rebillout@collabora.com" target="_blank">arnaud.rebillout@collabora.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello Go Packaging Team,<br>
<br>
I reached a milestone, I managed to get an up-to-date containerd package!<br></blockquote><div><br></div><div>Congratulations!</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I changed a bit my workflow and worked on my "personal staging area" in<br>
salsa, ie `<a href="http://salsa.debian.org/elboulangero-guest`" rel="noreferrer" target="_blank">salsa.debian.org/<wbr>elboulangero-guest`</a>, rather than directly<br>
in `<a href="http://salsa.debian.org/go-team`" rel="noreferrer" target="_blank">salsa.debian.org/go-team`</a>. I find it more convenient, I can mess<br>
around without bothering anyone.<br>
<br>
I also packaged several packages before asking a review, as I don'twant<br>
to waste your time with my iterations, and ask you to review thingsthat<br>
in the end are not needed.<br>
<br>
So now, the bad news is that there's quite a bunch of packages to review,<br>
but the good news is that if it's all good, then we have the latest<br>
containerd in Debian, and then we're closer to having docker packaged<br>
as well (I can't say exactly *how close* though...) !<br>
<br>
So here comes the review list, with links and comments !<br>
<br>
<br>
<br>
BUMPED PACKAGES<br>
---------------<br>
<br>
I forked the packages from `<a href="http://anonscm.debian.org" rel="noreferrer" target="_blank">anonscm.debian.org</a>` into my personal staging<br>
area `<a href="http://salsa.debian.org/elboulangero-guest`" rel="noreferrer" target="_blank">salsa.debian.org/<wbr>elboulangero-guest`</a>.<br>
<br>
I don't think I have write access to `<a href="http://anonscm.debian.org" rel="noreferrer" target="_blank">anonscm.debian.org</a>`, although I<br>
didn't try. I just don't want to mess up so it's more convenient to use<br>
my personal namespace on salsa.<br></blockquote><div><br></div><div>You are a pkg-go member on alioth, so you do have write access.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
I didn't touch the control urls in `debian/control`, so I believe that my<br>
changes can be merged into the <a href="http://anonscm.debian.org" rel="noreferrer" target="_blank">anonscm.debian.org</a> repository without any<br>
drama. Well, I hope :)<br>
<br>
#### containerd<br>
<<a href="https://salsa.debian.org/elboulangero-guest/containerd" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/containerd</a>><br>
- There's a lintian warning about package-contains-vcs-control-<wbr>file, but<br>
until<br>
now I didn't find the right way to remove a file from installation. I<br>
guess<br>
`override_dh_auto_install` is the way to go. Any hint welcome here.<br></blockquote><div><br></div><div>Which file specifically is affected? The Files-Excluded directive in debian/copyright is a good way to exclude files.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
- As for testing the thing really, I didn't go far yet, I just launched<br>
the binary, the log messages that appeared looked healthy enough, and<br>
that's all for now.<br>
<br>
#### golang-github-docker-go-events<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-events" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-docker-go-events</a>><br>
<br>
#### golang-github-docker-go-<wbr>metrics<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-docker-go-metrics" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-docker-go-metrics</a>><br>
<br>
#### golang-github-opencontainers-<wbr>image-spec<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-opencontainers-image-spec" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-opencontainers-image-<wbr>spec</a>><br>
- I noticed only after doing all the work that Michael Stapelberg was<br>
working on this package lately. I hope I don't duplicate the work.<br>
- The 3 last commits are probably not that good, please advise and I'll<br>
fix it.<br>
<br>
#### golang-github-prometheus-<wbr>client-golang<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-prometheus-client-golang" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-prometheus-client-<wbr>golang</a>><br>
<br>
<br>
<br>
NEW PACKAGES<br>
------------<br>
<br>
These packages live in my personal staging area, that is:<br>
`<a href="http://salsa.debian.org/elboulangero-guest`" rel="noreferrer" target="_blank">salsa.debian.org/<wbr>elboulangero-guest`</a>. However the control urls are set to<br>
`<a href="http://salsa.debian.org/go-team`" rel="noreferrer" target="_blank">salsa.debian.org/go-team`</a>, so I believe it's just a matter of moving the<br>
repository there if you give me your ack.<br>
<br>
#### continuity<br>
<<a href="https://salsa.debian.org/elboulangero-guest/continuity" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/continuity</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890983" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890983</a>><br>
- Produces continuity and golang-github-containerd-<wbr>continuity-dev.<br>
I looked at the existing packages docker and docker-containerd for<br>
guidance.<br>
- I ran the series of test described at<br>
<<a href="https://github.com/containerd/continuity" rel="noreferrer" target="_blank">https://github.com/<wbr>containerd/continuity</a>>,<br>
everything went fine.<br>
<br>
#### golang-gogottrpc<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-gogottrpc" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>gogottrpc</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890958" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890958</a>><br>
- Produces golang-gogottrpc and golang-github-stevvooe-ttrpc-<wbr>dev.<br>
I looked at the existing package golang-gogoprotobuf for guidance.<br>
- Patch and issues submitted upstream.<br>
<br>
#### golang-github-containerd-btrfs<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-btrfs" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-containerd-btrfs</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890989" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890989</a>><br>
- I disabled the test to avoid installing a btrfs-test binary, plus I<br>
think the<br>
test failed for some reason, I'm not sure to remember though...<br></blockquote><div><br></div><div>To avoid installing a binary, can you use the DH_GOLANG_EXCLUDES option please? See <a href="https://manpages.debian.org/testing/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html">https://manpages.debian.org/testing/dh-golang/Debian::Debhelper::Buildsystem::golang.3pm.en.html</a></div><div><br></div><div>Also, please add a comment stating why precisely the tests are disabled, and what needs to change so that we can re-enable them.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
#### golang-github-containerd-<wbr>typeurl<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-containerd-typeurl" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-containerd-typeurl</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891181" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=891181</a>><br>
- Patch submitted upstream<br>
<br>
#### golang-github-dmcgowan-go-tar<br>
<<a href="https://salsa.debian.org/elboulangero-guest/golang-github-dmcgowan-go-tar" rel="noreferrer" target="_blank">https://salsa.debian.org/<wbr>elboulangero-guest/golang-<wbr>github-dmcgowan-go-tar</a>><br>
<<a href="https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890960" rel="noreferrer" target="_blank">https://bugs.debian.org/cgi-<wbr>bin/bugreport.cgi?bug=890960</a>><br>
- This one was a tricky one, please read the commit messages for details.<br>
<br>
<br>
<br>
GENERAL QUESTIONS<br>
-----------------<br>
<br>
I see that most binaries come with the lintian warning<br>
`statically-linked-binary`, I guess it's just the way it works in the<br>
go world. Should I just add a lintian override ?<br></blockquote><div><br></div><div>lintian does not emit the statically-linked-binary tag for Go packages. Can you point me to a specific example where you see it please?</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
In the `-dev` packages, is `${shlibs:Depends}` needed ? During the builds<br>
I see `unknown substitution variable ${shlibs:Depends}` passing by.<br></blockquote><div><br></div><div>The messages implies it’s not required. I’m not entirely sure, but would suggest removing it for now.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
In the `-dev` packages, do we really need to copy-paste all the<br>
dependencies from the source package ?<br></blockquote><div><br></div><div>Yes. They differ in some cases, for example when code generation needs more dependencies than the actual compilation/test (in which case the extra dependencies show up only in Build-Depends, not Depends).</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
<br>
Thanks for reading, waiting for your feedback.<br>
<br>
Best regards,<br>
<br>
Arnaud<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Michael</div>
</div></div>